Skip to content

fix: code quality and safety improvements #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: code quality and safety improvements #3342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/api/metrics/activity/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,9 @@ export async function GET(req: NextRequest) {
let limit = limitParam ? parseInt(limitParam, 10) : 10;
let offset = offsetParam ? parseInt(offsetParam, 10) : 0;

if (isNaN(limit) || limit < 1) limit = 10;
if (Number.isNaN(limit) || limit < 1) limit = 10;
if (limit > 100) limit = 100;
if (isNaN(offset) || offset < 0) offset = 0;
if (Number.isNaN(offset) || offset < 0) offset = 0;

const bypass = isMetricsCacheBypassed(req);
const cacheKey = metricsCacheKey(
Expand Down
2 changes: 1 addition & 1 deletion src/app/api/metrics/contributions/hourly/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export async function GET(req: NextRequest) {

const daysParam = req.nextUrl.searchParams.get("days");
const parsedDays = daysParam ? parseInt(daysParam, 10) : NaN;
const days = isNaN(parsedDays) ? 30 : Math.max(1, Math.min(365, parsedDays));
const days = Number.isNaN(parsedDays) ? 30 : Math.max(1, Math.min(365, parsedDays));
const bypass = isMetricsCacheBypassed(req);
const key = metricsCacheKey(
session.githubId ?? session.githubLogin,
Expand Down
2 changes: 1 addition & 1 deletion src/app/api/metrics/contributions/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export async function GET(req: NextRequest) {
} else {
const daysParam = req.nextUrl.searchParams.get("days");
const parsedDays = daysParam ? parseInt(daysParam, 10) : NaN;
days = isNaN(parsedDays) ? 30 : Math.max(1, Math.min(365, parsedDays));
days = Number.isNaN(parsedDays) ? 30 : Math.max(1, Math.min(365, parsedDays));
}

const accountId = req.nextUrl.searchParams.get("accountId");
Expand Down
2 changes: 1 addition & 1 deletion src/app/api/metrics/productive-hours/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export async function GET(req: NextRequest) {
} else {
const daysParam = searchParams.get("days");
const parsedDays = daysParam ? parseInt(daysParam, 10) : NaN;
days = isNaN(parsedDays) ? 90 : Math.max(1, Math.min(365, parsedDays));
days = Number.isNaN(parsedDays) ? 90 : Math.max(1, Math.min(365, parsedDays));
}

const accountId = searchParams.get("accountId");
Expand Down
2 changes: 1 addition & 1 deletion src/app/api/metrics/repos/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ export async function GET(req: NextRequest) {
const daysParam = req.nextUrl.searchParams.get("days");
const parsedDays = daysParam ? parseInt(daysParam, 10) : NaN;
// Clamp days between 1 and 365 — GitHub Commit Search supports up to ~1 year lookback.
const days = isNaN(parsedDays) ? 30 : Math.max(1, Math.min(365, parsedDays));
const days = Number.isNaN(parsedDays) ? 30 : Math.max(1, Math.min(365, parsedDays));
const accountId = req.nextUrl.searchParams.get("accountId");
const bypass = isMetricsCacheBypassed(req);

Expand Down
Loading