Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed double validation on the message's content, added a scroll be… #947

Merged
merged 1 commit into from
Jan 30, 2025
Merged

removed double validation on the message's content, added a scroll be… #947

merged 1 commit into from
Jan 30, 2025

Conversation

Rigueur
Copy link

@Rigueur Rigueur commented Jan 30, 2025 •
edited by marien-probesys
Loading

…havior to the ticket show page so that it scroll down to answer form when form is not valid

Related issue(s)

#823

How to test manually

  • Go to an open ticket
  • Try to post an answer without writing anything (you can select time spent it doesnt change anything)
  • It should scroll you down to the form with the error message
  • If you quit the ticket and go back it shouldnt scroll you down

Reviewer checklist

  • Code is manually tested
  • Permissions / authorizations are verified
  • New data can be imported
  • Interface works on both mobiles and big screens
  • Interface works in both light and dark modes
  • Interface works on both Firefox and Chrome
  • Accessibility has been tested
  • Translations are synchronized
  • Tests are up to date
  • Copyright notices are up to date
  • Documentation is up to date
  • Pull request has been reviewed and approved

@Rigueur Rigueur linked an issue Jan 30, 2025 that may be closed by this pull request
The error message is duplicated when answering with no message #823
Closed
@marien-probesys marien-probesys force-pushed the 823-the-error-message-is-duplicated-when-answering-with-no-message branch from a96fa6a to f9ad014 Compare January 30, 2025 15:52
marien-probesys
marien-probesys approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@marien-probesys marien-probesys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marien-probesys marien-probesys merged commit f9ad014 into main Jan 30, 2025
6 checks passed
@marien-probesys marien-probesys deleted the 823-the-error-message-is-duplicated-when-answering-with-no-message branch January 30, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marien-probesys marien-probesys marien-probesys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The error message is duplicated when answering with no message
2 participants
@Rigueur @marien-probesys