fix: get_content() signature compatibility with Frappe v16#1
Merged
Conversation
Mirrors upstream PR developmentforpeople#44, which is open but not yet merged. Frappe v16's File.get_content() gained an `encodings` parameter; the DFPExternalStorageFile override was missing it, so any non-S3 file fetch crashed with TypeError: get_content() got an unexpected keyword argument 'encodings'. When upstream merges developmentforpeople#44, the next sync against developmentforpeople/dfp_external_storage:develop will overlap this file. Resolve by accepting upstream and dropping this patch. Refs: Profit-Rocket-Ltd/framework#11 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of upstream developmentforpeople/dfp_external_storage#44 ("fix: fix get_content() call for frappe v16 compatibility"), which is open but not yet merged.
Why we need this on our fork now
Profit Rocket runs
frappe/erpnext:v16.17.0. Frappe v16'sFile.get_content()added anencodingsparameter; ourDFPExternalStorageFile.get_content()override was missing it, so any non-S3 file fetch raises:```
TypeError: get_content() got an unexpected keyword argument 'encodings'
```
When this can be dropped
When upstream merges developmentforpeople#44, the next
scripts/check_upstream_sync.shrun will flag this fork asREVIEWwith one overlapping file (dfp_external_storage/dfp_external_storage/doctype/dfp_external_storage/dfp_external_storage.py). Resolve by accepting upstream and dropping this commit.References