Bug fixes #8
Closed
Bug fixes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added proper folders and files to external_libraries folder, and modified CMakeLists.txt to properly reflect the changes so that the build can be done correctly. Also changed CXX version to 17, from 14, as it was causing errors otherwise. * Added preliminary info to readme and changed header file organization and specified specific paths to the named header files in external_libraries for main.cpp and RouteController.cpp * Made one extra test to check enrollStudent() function in CourseUnitTests.cpp, and also added some preliminary text to citations.txt, bugs.txt, and README. Also made some basic style edits to RouteController.cpp based on cpplint's feedback. * Used namespaces in RouteController.h in order to shorten line lengths, and changed the corresponding types in RouteController.cpp to reflect to change. Also added one other test in CourseUnitTests.cpp * Added changes to MyApp.cpp to comply with cpplint's warnings, and moved one of the linked I used from README to citations.txt * Finished making changes to MyApp.cpp and RouteController.cpp in terms of style checks using cpplint * Fixed style issues for course.cpp and department.cpp based on warnings provided by cpplint * Finished globals.cpp, myfiledatabase.cpp, and main.cpp in terms of style check using cpplint. Also finished course.h style check * Finished all the edits for the style checks regarding the header files in the include directory
…s in citations.txt to account for the sources I used as I tried to navigate around installation issues with clang-tidy. Finally, added some additional text to README regarding the setup info, specifically regarding clang-tidy and how I installed and set everything up.
…ing gcc. Made necessary edits to CMakeLists.txt and for now the part regarding static analysis with clang-tidy is commented out as it is too slow. Also added the necessary information to use the coverage analysis tool govc in README.
…ith Course.cpp that clang-tidy was warning about. Also documented these changes in bugs.txt
…umented the changes to bugs.txt. Also started added some details to citations.txt. And also finished with more bugs for Course.cpp
…ed unnecessary files in the build directory.
…was not returning anything, also added the contents of the external libraries of the folder external_libraries in gitignore.
|
This pull request has been automatically closed because it was opened in the upstream repository. Create your PRs within your own forked repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.