-
Notifications
You must be signed in to change notification settings - Fork 3
[WIP] Rewrite bubble detection. #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Balletie
wants to merge
24
commits into
ProgrammingLife2015:master
Choose a base branch
from
Balletie:skip-cluster-bubble-rewrite-bubbling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Rewrite bubble detection. #181
Balletie
wants to merge
24
commits into
ProgrammingLife2015:master
from
Balletie:skip-cluster-bubble-rewrite-bubbling
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle nested bubbles, so that only their outer bubbles are collapsed. Fix bubbles with paths of length 1 and 0 (indels).
…n outside of range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #161, this branch attempts to reimplement bubble detection to guard against overlapping bubbles.
Mirror branch is in this repository at branch
skip-cluster-bubble-rewrite-bubbling
.