Skip to content

AAA Option Optimizer #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from
Draft

AAA Option Optimizer #271

wants to merge 22 commits into from

Conversation

ilicfilip
Copy link
Collaborator

Context

This PR adds a suggested task when high number of autoloaded options is detected and it instructs user to install AAA Option Optimizer plugin.

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have added unit tests to verify the code works as intended.
  • I have checked that the base branch is correctly set.

Copy link
Contributor

github-actions bot commented Feb 14, 2025

Test on Playground
Test this pull request on the Playground or download the zip.

$this->title = \esc_html__( 'Reduce number of autoloaded options', 'progress-planner' );
$this->description = sprintf(
// translators: %d is the number of autoloaded options.
\esc_html__( 'There are %d autoloaded options. If you don\'t need them, consider disabling them by installing the "AAA Option Optimizer" plugin.', 'progress-planner' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt normal users will understand or know whether they need autoloading options or not, and we should make it clear that this is a performance improvement

Suggested change
\esc_html__( 'There are %d autoloaded options. If you don\'t need them, consider disabling them by installing the "AAA Option Optimizer" plugin.', 'progress-planner' ),
\esc_html__( 'There are %d autoloaded options. Consider installing the "AAA Option Optimizer" plugin to improve performance.', 'progress-planner' ),

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, wording was just a placeholder during WIP and it needs to be improved - that is the one for @tacoverdo and @irisgue , if we decide to merge it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants