-
Notifications
You must be signed in to change notification settings - Fork 1
Interactive task type #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ilicfilip
wants to merge
22
commits into
develop
Choose a base branch
from
filip/interactive-task
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+418
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test on Playground |
aristath
reviewed
Feb 21, 2025
@Mijke , @tacoverdo here is the screen recording of the current state of the Interactive task (checking if email sending is working): Screen.Recording.2025-04-17.at.15.12.55.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Implementation of https://github.com/ProgressPlanner/progress-planner-pro/issues/86
This PR adds example of interactive task, when clicking on a task user gets a popover which let him tests if sending emails is working on his site. If user confirms that sending email is working task will be celebrated, if not user gets an instruction on how to fix it.
Technically, idea is to add interactive part as a custom web component so we can change it any way we want without touching the rest of the code base.
The PHP class for this task type should also contain all relevant code, in this case it is a AJAX callback which sends an email.
Summary
Added task for checking if sending emails is working.
Quality assurance