Skip to content

Comments

Fix ColorPicker Height if it doesn't fit on screen#113

Merged
martinmine merged 5 commits intoProjectCeleste:masterfrom
CWO333:ColorPicker-Height-Fix
Oct 26, 2025
Merged

Fix ColorPicker Height if it doesn't fit on screen#113
martinmine merged 5 commits intoProjectCeleste:masterfrom
CWO333:ColorPicker-Height-Fix

Conversation

@CWO333
Copy link
Contributor

@CWO333 CWO333 commented Oct 22, 2025

Just a small change to the Color Picker so it will show properly to those who may not have 950px+ height for their screen resolution. Some older HD monitors are 1366x768 which will make the Color Picker impossible to use. I added a vertical scrollbar that will only show if the height is restricted and it will lower the height of the form to Resolution height - 100.

@martinmine
Copy link
Contributor

From a visual aspect I think it could be handled a bit better but I think this is sufficient for those edge-cases where players don't have a high enough resolution on their monitor. Also got some feedback from some that even on 1920x1080 resolution, they could face challenges with this window because the UI scaling in Windows was set to 125%. Having scaling set to 100% in those cases would be good enough for the window to show correctly.

It looks like this on my system with the side bar: image

@CWO333
Copy link
Contributor Author

CWO333 commented Oct 24, 2025

So Sonicflare and I were talking through the whole process and he came up with a better way. The window itself will automatically be scaled down instead of becoming scrollable. I experimented a bit and this will work all the way down to a height of 634. It also worked with 1080 with 125% scaling.

Untitled

@martinmine
Copy link
Contributor

That looks interesting. Any chance you can make it follow the aspect ratio? As with your proof of concept it only scales the height of the window. This leads to that the window becomes stretched and the header (the color picker title) becomes misaligned with the background.

Keep aspect ratio when resizing window
@CWO333
Copy link
Contributor Author

CWO333 commented Oct 25, 2025

Mostly fixed the aspect ratio with a close approximation. It's barely a bit off but only by a few pixels.
Untitled

@martinmine martinmine merged commit 9863dba into ProjectCeleste:master Oct 26, 2025
1 check passed
@martinmine
Copy link
Contributor

Awesome work, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants