Fix ColorPicker Height if it doesn't fit on screen#113
Merged
martinmine merged 5 commits intoProjectCeleste:masterfrom Oct 26, 2025
Merged
Fix ColorPicker Height if it doesn't fit on screen#113martinmine merged 5 commits intoProjectCeleste:masterfrom
martinmine merged 5 commits intoProjectCeleste:masterfrom
Conversation
…user's Screen Resolution is too small.
Contributor
|
From a visual aspect I think it could be handled a bit better but I think this is sufficient for those edge-cases where players don't have a high enough resolution on their monitor. Also got some feedback from some that even on 1920x1080 resolution, they could face challenges with this window because the UI scaling in Windows was set to 125%. Having scaling set to 100% in those cases would be good enough for the window to show correctly. |
Solution provided by Sonicflare
Contributor
Author
Contributor
|
That looks interesting. Any chance you can make it follow the aspect ratio? As with your proof of concept it only scales the height of the window. This leads to that the window becomes stretched and the header (the color picker title) becomes misaligned with the background. |
Keep aspect ratio when resizing window
Contributor
Author
Contributor
|
Awesome work, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Just a small change to the Color Picker so it will show properly to those who may not have 950px+ height for their screen resolution. Some older HD monitors are 1366x768 which will make the Color Picker impossible to use. I added a vertical scrollbar that will only show if the height is restricted and it will lower the height of the form to Resolution height - 100.