Return typed ratelimit error including retry-after header #1671
Conversation
src/api/api.ts
Outdated
| @@ -755,6 +756,19 @@ export class OpenSeaAPI { | |||
|
|
|||
| const response = await req.send(); | |||
| if (!response.ok()) { | |||
| if (response.statusCode === 599) { | |||
There was a problem hiding this comment.
I could also use the standard 429 status code here to make the clause future-proof.
There was a problem hiding this comment.
429 makes sense, not sure if it should be catching 599 for rate limit?
There was a problem hiding this comment.
This is the status code currently returned from the API (likely a proxy under your control sitting in front of the actual API).
0xmichalis
force-pushed
the
typed-429-error
branch
from
ad90c1f to
e3276c2
Compare
|
thanks for this PR! it's much appreciated, and sorry it took me so long to review. i'm concerned it might break people's implementations though by throwing a different error if we release it in a patch version. what is the current error response when you get rate limited? i do think it's useful to return the retryAfter data, but maybe we can just add it to the end of the existing error message and it can be grepped? not ideal, but just one thought. |
Fixes #1668