Skip to content

feat: add conduit for Abstract - #1715

Merged
ryanio merged 4 commits into
mainfrom
devin/1737769268-add-conduit-constants
Jul 15, 2025
Merged

feat: add conduit for Abstract#1715
ryanio merged 4 commits into
mainfrom
devin/1737769268-add-conduit-constants

Conversation

@ryanio

@ryanio ryanio commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator

Add Abstract Chain Conduit Configuration

Summary

This PR implements chain-specific conduit configuration for seaport-js initialization, focusing on Abstract chain support. The changes introduce a getDefaultConduit(chain) helper function and update the Seaport initialization to use conduitKeyToConduit mapping with dynamic defaultConduitKey selection.

Key Changes:

  • Added OPENSEA_CONDUIT_ADDRESS_2 and OPENSEA_CONDUIT_KEY_2 constants for Abstract chain
  • Created getDefaultConduit(chain) helper function in src/utils/utils.ts
  • Updated Seaport initialization in src/sdk.ts to use conduit mapping and dynamic default conduit key

Behavior Changes:

  • Abstract chain now uses OPENSEA_CONDUIT_KEY_2 as the default conduit key
  • All other chains fall back to the standard OPENSEA_CONDUIT_KEY from seaport-js
  • Seaport initialization now includes conduit key-to-address mapping for proper resolution

Review & Testing Checklist for Human

🟡 Medium Risk - 3 items to verify:

  • Verify conduit constants are correct for Abstract chain - Double-check that OPENSEA_CONDUIT_ADDRESS_2 (0x963f00d3ff000064ffcba824b800c0000000c300) and OPENSEA_CONDUIT_KEY_2 (0x61159fefdfada89302ed55f8b9e89e2d67d8258712b3a3f89aa88525877f1d5e) match the official Abstract chain conduit deployment
  • Test order creation on Abstract chain - Create a test order on Abstract chain to verify the conduit configuration works end-to-end and orders can be properly created and fulfilled
  • Verify fallback behavior for other chains - Test order creation on a non-Abstract chain (e.g., Ethereum mainnet) to ensure the fallback to default conduit key works correctly and doesn't break existing functionality

Recommended Test Plan:

  1. Deploy to staging environment
  2. Test order creation on Abstract chain with the new conduit configuration
  3. Test order creation on Ethereum mainnet to verify no regression
  4. Verify that getDefaultConduit() returns expected values for various chains

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    constants["src/constants.ts<br/>OPENSEA_CONDUIT_*_2"]:::major-edit
    utils["src/utils/utils.ts<br/>getDefaultConduit()"]:::major-edit
    sdk["src/sdk.ts<br/>Seaport initialization"]:::major-edit
    seaport["@opensea/seaport-js<br/>conduitKeyToConduit"]:::context
    
    constants --> sdk
    utils --> sdk
    sdk --> seaport
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit
        L3[Context/No Edit]:::context
    end

classDef major-edit fill:#90EE90
classDef minor-edit fill:#87CEEB
classDef context fill:#FFFFFF
Loading

Notes

@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@ryanio ryanio changed the title feat: add conduit constants for Abstract and Gunzilla chains feat: add conduit constants for Abstract Jul 15, 2025
@ProjectOpenSea ProjectOpenSea deleted a comment from devin-ai-integration Bot Jul 15, 2025
@ryanio ryanio changed the title feat: add conduit constants for Abstract feat: add conduit for Abstract Jul 15, 2025
@ryanio
ryanio force-pushed the devin/1737769268-add-conduit-constants branch from 7a22f0c to 7669d74 Compare July 15, 2025 02:01
@ryanio
ryanio merged commit 2bf8868 into main Jul 15, 2025
6 of 7 checks passed
@ryanio
ryanio deleted the devin/1737769268-add-conduit-constants branch July 15, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant