feat: add conduit for Abstract - #1715
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
ryanio
force-pushed
the
devin/1737769268-add-conduit-constants
branch
from
July 15, 2025 02:01
7a22f0c to
7669d74
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Abstract Chain Conduit Configuration
Summary
This PR implements chain-specific conduit configuration for seaport-js initialization, focusing on Abstract chain support. The changes introduce a
getDefaultConduit(chain)helper function and update the Seaport initialization to useconduitKeyToConduitmapping with dynamicdefaultConduitKeyselection.Key Changes:
OPENSEA_CONDUIT_ADDRESS_2andOPENSEA_CONDUIT_KEY_2constants for Abstract chaingetDefaultConduit(chain)helper function insrc/utils/utils.tssrc/sdk.tsto use conduit mapping and dynamic default conduit keyBehavior Changes:
OPENSEA_CONDUIT_KEY_2as the default conduit keyOPENSEA_CONDUIT_KEYfrom seaport-jsReview & Testing Checklist for Human
🟡 Medium Risk - 3 items to verify:
OPENSEA_CONDUIT_ADDRESS_2(0x963f00d3ff000064ffcba824b800c0000000c300) andOPENSEA_CONDUIT_KEY_2(0x61159fefdfada89302ed55f8b9e89e2d67d8258712b3a3f89aa88525877f1d5e) match the official Abstract chain conduit deploymentRecommended Test Plan:
getDefaultConduit()returns expected values for various chainsDiagram
%%{ init : { "theme" : "default" }}%% graph TD constants["src/constants.ts<br/>OPENSEA_CONDUIT_*_2"]:::major-edit utils["src/utils/utils.ts<br/>getDefaultConduit()"]:::major-edit sdk["src/sdk.ts<br/>Seaport initialization"]:::major-edit seaport["@opensea/seaport-js<br/>conduitKeyToConduit"]:::context constants --> sdk utils --> sdk sdk --> seaport subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes