-
Notifications
You must be signed in to change notification settings - Fork 4
Add Missing Logs Across Platform for Key Events and Actions #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
|
||
logger = logging.getLogger(__name__) | ||
router = APIRouter(tags=["private"], prefix="/private") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think that we need to implement logging in this file since it is not being used, and also not needed for project_user route as well since we already have a project user relationship with the api key generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just keep it, may be if we need in future or if we remove code logging will be removed also
from sqlmodel import Session, select, delete, func | ||
from app.models import ProjectUser, ProjectUserPublic, User, Project | ||
from datetime import datetime, timezone | ||
|
||
from app.core.util import now | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
def is_project_admin(session: Session, user_id: int, project_id: int) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above
This PR introduces comprehensive logging across the platform to improve observability, traceability, and debugging efficiency.
Target issue : #213 and #234