Fix testing #42
Open
Fix testing #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the provided instructions for installing Go and Docker on my machine, then ran the provided make commands to run the backend and frontend tests. I identified that the app needed to support case-insensitive queries and fetching up to 20 results max at a time and implemented my changes accordingly. I focused on the frontend first and then isolated key sections of the backend code to finish plumbing through the pagination feature (for capping the initial search API response size, as well as implementing the "Load more" button functionality) and tweaking the search to be case-insensitive. I was able to confirm that all backend tests were passing, however, ran into various issues while running the frontend test suite. This took more time than anticipated as I worked to resolve Docker issues such as permissions and space constraints. After becoming more familiar with Golang, I was able to get the frontend tests running and verify that all cases were fixed accordingly.