Skip to content

Commit 4aa0fc0

Browse files
committed
Remove completed todo.
Signed-off-by: Arris Ray <[email protected]>
1 parent 45f0e8f commit 4aa0fc0

File tree

2 files changed

+28
-29
lines changed

2 files changed

+28
-29
lines changed

src/Prometheus/Storage/RedisTxn.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
* This adapter refactors the {@see \Prometheus\Storage\RedisNg} adapter to generally try and execute the "update" and
3232
* "collect" operations of each metric type within a single Redis transaction.
3333
*
34-
* @todo Only summary metrics have been refactored so far. Complete refactor for counter, gauge, and histogram metrics.
3534
* @todo Reimplement wipeStorage() to account for reorganized keys in Redis.
3635
* @todo Reimplement all Redis scripts with redis.pcall() to trap runtime errors that are ignored by redis.call().
3736
*/

tests/Test/Benchmark/BenchmarkTest.php

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -32,34 +32,34 @@ public static function setUpBeforeClass(): void
3232
public function benchmarkProvider(): array
3333
{
3434
return [
35-
// [AdapterType::REDISNG, MetricType::COUNTER, 1000, 10],
36-
// [AdapterType::REDISNG, MetricType::COUNTER, 2000, 10],
37-
// [AdapterType::REDISNG, MetricType::COUNTER, 5000, 10],
38-
// [AdapterType::REDISNG, MetricType::COUNTER, 10000, 10],
39-
// [AdapterType::REDISNG, MetricType::GAUGE, 1000, 10],
40-
// [AdapterType::REDISNG, MetricType::GAUGE, 2000, 10],
41-
// [AdapterType::REDISNG, MetricType::GAUGE, 5000, 10],
42-
// [AdapterType::REDISNG, MetricType::GAUGE, 10000, 10],
43-
// [AdapterType::REDISNG, MetricType::HISTOGRAM, 1000, 10],
44-
// [AdapterType::REDISNG, MetricType::HISTOGRAM, 2000, 10],
45-
// [AdapterType::REDISNG, MetricType::HISTOGRAM, 5000, 10],
46-
// [AdapterType::REDISNG, MetricType::HISTOGRAM, 10000, 10],
47-
// [AdapterType::REDISNG, MetricType::SUMMARY, 1000, 10],
48-
// [AdapterType::REDISNG, MetricType::SUMMARY, 2000, 10],
49-
// [AdapterType::REDISNG, MetricType::SUMMARY, 5000, 10],
50-
// [AdapterType::REDISNG, MetricType::SUMMARY, 10000, 10],
51-
// [AdapterType::REDISTXN, MetricType::COUNTER, 1000, 10],
52-
// [AdapterType::REDISTXN, MetricType::COUNTER, 2000, 10],
53-
// [AdapterType::REDISTXN, MetricType::COUNTER, 5000, 10],
54-
// [AdapterType::REDISTXN, MetricType::COUNTER, 10000, 10],
55-
// [AdapterType::REDISTXN, MetricType::GAUGE, 1000, 10],
56-
// [AdapterType::REDISTXN, MetricType::GAUGE, 2000, 10],
57-
// [AdapterType::REDISTXN, MetricType::GAUGE, 5000, 10],
58-
// [AdapterType::REDISTXN, MetricType::GAUGE, 10000, 10],
59-
// [AdapterType::REDISTXN, MetricType::HISTOGRAM, 1000, 10],
60-
// [AdapterType::REDISTXN, MetricType::HISTOGRAM, 2000, 10],
61-
// [AdapterType::REDISTXN, MetricType::HISTOGRAM, 5000, 10],
62-
// [AdapterType::REDISTXN, MetricType::HISTOGRAM, 10000, 10],
35+
[AdapterType::REDISNG, MetricType::COUNTER, 1000, 10],
36+
[AdapterType::REDISNG, MetricType::COUNTER, 2000, 10],
37+
[AdapterType::REDISNG, MetricType::COUNTER, 5000, 10],
38+
[AdapterType::REDISNG, MetricType::COUNTER, 10000, 10],
39+
[AdapterType::REDISNG, MetricType::GAUGE, 1000, 10],
40+
[AdapterType::REDISNG, MetricType::GAUGE, 2000, 10],
41+
[AdapterType::REDISNG, MetricType::GAUGE, 5000, 10],
42+
[AdapterType::REDISNG, MetricType::GAUGE, 10000, 10],
43+
[AdapterType::REDISNG, MetricType::HISTOGRAM, 1000, 10],
44+
[AdapterType::REDISNG, MetricType::HISTOGRAM, 2000, 10],
45+
[AdapterType::REDISNG, MetricType::HISTOGRAM, 5000, 10],
46+
[AdapterType::REDISNG, MetricType::HISTOGRAM, 10000, 10],
47+
[AdapterType::REDISNG, MetricType::SUMMARY, 1000, 10],
48+
[AdapterType::REDISNG, MetricType::SUMMARY, 2000, 10],
49+
[AdapterType::REDISNG, MetricType::SUMMARY, 5000, 10],
50+
[AdapterType::REDISNG, MetricType::SUMMARY, 10000, 10],
51+
[AdapterType::REDISTXN, MetricType::COUNTER, 1000, 10],
52+
[AdapterType::REDISTXN, MetricType::COUNTER, 2000, 10],
53+
[AdapterType::REDISTXN, MetricType::COUNTER, 5000, 10],
54+
[AdapterType::REDISTXN, MetricType::COUNTER, 10000, 10],
55+
[AdapterType::REDISTXN, MetricType::GAUGE, 1000, 10],
56+
[AdapterType::REDISTXN, MetricType::GAUGE, 2000, 10],
57+
[AdapterType::REDISTXN, MetricType::GAUGE, 5000, 10],
58+
[AdapterType::REDISTXN, MetricType::GAUGE, 10000, 10],
59+
[AdapterType::REDISTXN, MetricType::HISTOGRAM, 1000, 10],
60+
[AdapterType::REDISTXN, MetricType::HISTOGRAM, 2000, 10],
61+
[AdapterType::REDISTXN, MetricType::HISTOGRAM, 5000, 10],
62+
[AdapterType::REDISTXN, MetricType::HISTOGRAM, 10000, 10],
6363
[AdapterType::REDISTXN, MetricType::SUMMARY, 1000, 10],
6464
[AdapterType::REDISTXN, MetricType::SUMMARY, 2000, 10],
6565
[AdapterType::REDISTXN, MetricType::SUMMARY, 5000, 10],

0 commit comments

Comments
 (0)