Add support to render XML namespace #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijnh
reviewed
Jan 7, 2020
test/test-dom.js
Outdated
|
|
||
| ist(derivedDOM.innerHTML, declaredDOM.innerHTML) | ||
| console.log(derivedDOM.innerHTML); |
There was a problem hiding this comment.
This looks like a leftover debugging statement.
marijnh
reviewed
Jan 7, 2020
src/to_dom.js
Outdated
| if (typeof structure == "string") | ||
| return {dom: doc.createTextNode(structure)} | ||
| if (structure.nodeType != null) | ||
| return {dom: structure} | ||
| let dom = doc.createElement(structure[0]), contentDOM = null | ||
| let contentDOM = null | ||
| let [xmlns, tag] = structure[0].split(' ', 2) |
There was a problem hiding this comment.
Could you do something involving structure[0].indexOf(" ") to check for the presence of a space, to avoid allocating another array for every element?
marijnh
reviewed
Jan 7, 2020
src/to_dom.js
Outdated
| @@ -4,7 +4,8 @@ | |||
| // itself, or an array. | |||
| // | |||
| // An array describes a DOM element. The first value in the array | |||
| // should be a string—the name of the DOM element. If the second | |||
| // should be a string—the name of the DOM element. It also can be | |||
| // space-separated the XML namespace and the name. If the second | |||
There was a problem hiding this comment.
"the name of the DOM element, optionally prefixed by a namespace URL and a space." is probably a better phrasing.
|
@marijnh Thank you for your reviewing! If you'd like, I'll squash them to one. Thanks. |
|
Thank you. Merged as 66df625, released as 1.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add support to render XML namespace with
toDOMfunction.Usage
This pull request will expand the first item of returned value of
toDOMfunction.It will receive space-separated string. The first one is XML namespace, and the second is element name.
We can also use XML namespace for attributes in the same way.
related issue