forked from meetecho/janode
-
Notifications
You must be signed in to change notification settings - Fork 0
Merge latest changes #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
auriv
wants to merge
121
commits into
Proximie:master
Choose a base branch
from
meetecho:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t" and 1.x "autoupdate"
add host_family to startForward
- Support "streams" and "descriptions" parameters for configure and publish requests - Add "streams" object when a subscriber joins
Add main entry point
The plugin handles: - register with different mechanisms - simple ingoing and outgoing calls - dtmf tones (SIP INFO and RFC2833) BREAKING CHANGES The support for SIP plugin has two important effects on the Janode core: - Due to the nature of SIP, transactions may now timeout, hence the sendRequest has now a second parameter timeout_ms that defaults to 0 (no timeout). - Transactions will not be automatically closed with success by the core in case of truthy returns from the specialized plugin handleMessage. That is needed to keep transactions open even when handling intermediate events (e.g. INVITE tx should not be closed by a RINGING). As a consequence, plugins must now define every case of successful tx issuing closeTransactionWithSucces whenever it's needed.
Co-authored-by: Alessandro Toppi <[email protected]>
Note: this patch only covers the TextRoom functionality that can be used via Janus API. Room participation is excluded, since that's only available via datachannels messaging, and so out of reach of the library itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest changes