measurement schema 增 run_kind / decode-determinism provenance 欄位(follow-up from #109 verify) - #119
Merged
kiki830621 merged 1 commit intoJul 30, 2026
Conversation
#111) Add two optional provenance fields to MeasurementRow + SubmissionRow, mirroring the hf_revision precedent (optional, nil-default, snake_case CodingKeys, synthesized-Codable free backward-compat — legacy rows decode to nil): - run_kind (String?, release-sweep|adhoc|nil): distinguishes release-sweep's full-matrix snapshot rows from ad-hoc submissions so per-version snapshot census completeness is mechanically checkable. Threaded via a new 'bestasr benchmark --run-kind' flag; release-sweep.sh passes release-sweep. - decode_deterministic (Bool?): HONEST tri-state — true/false only for backends that consume --decode-deterministic (WhisperKit / whisper.cpp, gated via ModelGrid.backendWhisperKit/WhisperCpp); nil for mlx-audio (silent no-op) and legacy rows. Never claims a value for a backend that ignored the flag. The representation-upgrade decision (Bool?+nil vs per-backend enum) is #118. The legacy flat-cache migration path (BenchmarkStore) has no run-kind/decode info in scope and passes nil/nil (legacy-safe). 5 new backward-compat tests; full suite (389) green. Refs #111
Member
Author
Verify Report — PR #119 (#111)Enginemanual fan-out (4 lens Agents + sequenced DA, model: opus, file-based output) + Codex (gpt-5.x) — Codex leg incomplete(HTTP 429 usage_limit_reached,同 #112 verify 的 ChatGPT Pro plan limit,reset ~5.4 天)。跨模型盲驗本輪缺席,fail-closed INFO,不當 PASS 計。5 個 Claude reviewer(4 lens + DA)完整。 AggregatePASS — 0 blocking, 1 follow-up filed (#120)。
要求覆蓋率5 / 5 requirements addressed — FULLY(+ 跨 repo contract exact match)。 Findings(合併後)
Scope Check無超出 #111(re-scoped Plan)範圍。determinism 表示法 enum 正確拆至 #118;hardening 護欄拆至 #120。 Process Gaps
Follow-up Findings Filed (v2.72.0+ #148)
紀律聲明
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #111
Summary
Add two optional provenance fields to the measurement schema (
MeasurementRow+SubmissionRow), mirroring the existinghf_revisionprecedent (optional, nil-default, snake_case CodingKeys, synthesized-Codable free backward-compat):run_kind(String?,release-sweep|adhoc|nil) — distinguishes release-sweep full-matrix snapshot rows from ad-hoc submissions so per-version snapshot census completeness is mechanically checkable. Newbestasr benchmark --run-kindflag;release-sweep.shpassesrelease-sweep.decode_deterministic(Bool?) — HONEST tri-state: true/false only for backends that consume--decode-deterministic(WhisperKit/whisper.cpp, gated viaModelGrid.backendWhisperKit/WhisperCpp); nil for mlx-audio (silent no-op) and legacy rows. Never claims a value for a backend that ignored the flag.Re-scoped from Spectra → Plan per user decision (#111 Re-scope comment). The determinism representation upgrade (Bool?+nil vs per-backend enum) is deferred to #118.
bestASR-bench synced separately (direct-commit to bench main, commit
e728f1a): validator gains optional-when-present checks (fields kept OUT of REQUIRED so existing 156 rows pass); SUBMISSION_FORMAT.md documents both.Verification
swift buildclean; 5 new backward-compat tests (legacy decode→nil, round-trip, nil-encodes-absent, packager threads provenance) + full suite 389 green, none skipped.run_kind/decode_deterministicrejected; 156 legacy rows stillOK; valid new-fields rows pass.Checklist
Generated by /idd-implement on PR path. Do NOT add a GitHub close trailer — IDD discipline requires manual /idd-close after merge.