Give mcpb/manifest.json's version an owner in the release pipeline (Refs #311) - #325
Merged
Conversation
The field froze at 2.7.2 for ~18 releases — no release tooling referenced it, and the drift was masked because Server.swift's then-hardcoded handshake version had rotted to the same value (the two wrong sources agreed by coincidence; PR #307's dynamic handshake exposes it). - mcpb/manifest.json bumped to the current release (2.25.0) - release.sh dies when the manifest disagrees with the tag (fail-closed; JSON-parsed via python3, not grepped — it is JSON, read it as JSON; deliberately not auto-edited: the script requires a clean tree, so editing mid-release would contradict its own precondition) - ManifestVersionTests pins manifest == newest released CHANGELOG header (RED at 2.7.2 vs 2.25.0 before the bump, GREEN after) 1069 tests, 0 failures. Refs #311
Member
Author
Verify: PR #325 (Refs #311)EngineClaude lens (sonnet, read-only from PR diff + branch files) — Codex cross-model lens unavailable (usage limit until Aug 5); single-family verify, noted per batch discipline. Result: PASS — no blocking findings
Process notes: repo has no swift-test CI (CodeQL only) so the 1069/0 figure is author-machine-only; the verifier did not run the suite (working tree off-limits during batch). Diff hygiene: manifest array pretty-printing is a JSON-library side effect (values verified unchanged); the second Verify-gated: PASS — ready for review/merge. After merge: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #311
Summary
mcpb/manifest.json's version froze at 2.7.2 for ~18 releases — nothing owned it, andServer.swift's coincidentally-identical hardcoded handshake masked it. This PR bumps it to 2.25.0, adds a fail-closedrelease.shcheck (manifest must equal the tag), and pins the invariant in CI viaManifestVersionTests(manifest == newest released CHANGELOG header). RED-first: the test failed at2.7.2 != 2.25.0before the bump.Coordination note
Shares
scripts/release.shwith unmerged PR #307 (different region — #307's guard block sits adjacent). Whichever merges second resolves a trivial textual conflict; semantics are independent.Verification
🤖 Generated by /idd-all. Do NOT add a GitHub close trailer — run /idd-close after merge.