feat: wip- acl cleanup script and other cleanup#76
Open
ksatyarth2 wants to merge 6 commits intomasterfrom
Open
feat: wip- acl cleanup script and other cleanup#76ksatyarth2 wants to merge 6 commits intomasterfrom
ksatyarth2 wants to merge 6 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
eladiosch
reviewed
Apr 24, 2025
| return 0xb4F1f4d59bd7590e92c386083Aa260C1e09cC58b; | ||
| } else if (block.chainid == holesky) { | ||
| // https://holesky.etherscan.io/address/0xDDDeAfB492752FC64220ddB3E7C9f1d5CcCdFdF0 | ||
| return 0xDDDeAfB492752FC64220ddB3E7C9f1d5CcCdFdF0; |
Contributor
There was a problem hiding this comment.
Should we change this address?
eladiosch
reviewed
Apr 24, 2025
| } | ||
| // Keep this address for revoking old paymaster in future | ||
|
|
||
| function _getDeprecatedPaymaster() internal view returns (address) { |
Contributor
There was a problem hiding this comment.
Why is this function necessary?
eladiosch
reviewed
Apr 24, 2025
| @@ -0,0 +1,111 @@ | |||
| // SPDX-License-Identifier: GPL-3.0 | |||
| pragma solidity >=0.8.0 <0.9.0; | |||
Contributor
There was a problem hiding this comment.
This is the 3rd file that starts by 07_. We should rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.