Skip to content

Pull request for all current work on the rave veridise audit fixes #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertsdotpm wants to merge 36 commits into
base: veridise-audit
Choose a base branch
from
Open

Pull request for all current work on the rave veridise audit fixes #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
586cd4f
Simplified commands for generating rave() ABI hex and func signatures.
Aug 17, 2023
ba8d661
fix tests
kamiyaa Aug 17, 2023
c8b1386
Merge pull request #1 from kamiyaa/jeff
robertsdotpm Aug 21, 2023
7565949
Working on making DER decoder safer.
Aug 21, 2023
7be761c
Saving checks for read no length and root.
Aug 21, 2023
3b1a622
Slowly testing DER.
Aug 22, 2023
49ff0f4
Saving ASN.1 tests.
Aug 22, 2023
89e6ad6
Child functions left to test.
Aug 22, 2023
d7a8e83
ANS1 patches done.
Aug 22, 2023
a081d1a
Apply some overflow checks to the pointer packer.
Aug 22, 2023
d4c4d7e
Apparently uint is just uint256.
Aug 22, 2023
d3e1fe1
Reject multitag identifiers.
Aug 22, 2023
4b4a99a
Added new code to support zero length content. Need to expand tests t…
Aug 23, 2023
27d0e3c
Saving progress on value tests.
Aug 23, 2023
c0bacbc
Adding test value checks.
Aug 23, 2023
a6655fc
Working on value checks.
Aug 23, 2023
c6e7a36
Software should handle zero len content fields now.
Aug 23, 2023
9269bc1
Get verify child cert working again.
Aug 23, 2023
81b2fff
All tests seem to work again.
Aug 23, 2023
4ef96a1
Renable all tests
Aug 23, 2023
3adee57
Saving progress fixing tests.
Aug 23, 2023
48d8945
working on fixing broken tests.
Aug 24, 2023
9ac5a1a
Saving progress on fixing tests.
Aug 24, 2023
2a01140
Tests failing due to race conditions.
Aug 24, 2023
be4e1ed
Fix broken tests.
Aug 24, 2023
875ee26
Extra checks for errors near sensitive math prone to underflows.
Aug 24, 2023
2aa9595
Add check for RSA algorithm ID.
Sep 4, 2023
0a28a57
Add checks for sig algorithm. Need to avoid declaring too many variab…
Sep 4, 2023
2c8826d
Adding fixed params for Intel root CA.
Sep 20, 2023
3800a27
Add more comments in RAVE due to its complexity.
Sep 20, 2023
f89b008
Typo.
Sep 20, 2023
2f9acb5
This test proves that the hard coded root params are being used.
Sep 20, 2023
b31f711
Add suggested fixes. Rave sanity checker is flaky and still succeedin…
Sep 20, 2023
2b98ea6
Saving progress on x509 validity periods.
Sep 21, 2023
0b4ecee
Working on date time checks.
Oct 30, 2023
fa5f712
Saving.
Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,12 @@ env/
.vscode
test/mocks/evidence.json
test/scripts/ss_out
test/scripts/bin/error.log
*ss_out*

# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]

# Log file I use for test output.
all.txt
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@
path = lib/openzeppelin-contracts
url = https://github.com/openzeppelin/openzeppelin-contracts
branch = v4.9.1
[submodule "lib/ethereum-datetime"]
path = lib/ethereum-datetime
url = https://github.com/pipermerriam/ethereum-datetime.git
1 change: 1 addition & 0 deletions lib/ethereum-datetime
Open in desktop
Submodule ethereum-datetime added at 7a08a9
28 changes: 28 additions & 0 deletions out.key
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
-----BEGIN PRIVATE KEY-----
MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQDPimz4/B0p2TVY
Sxl7mc8Ju6M62gXfldZGr8PFcURI3ajcbYxBGwbzNHNP/sP/CwGZ4zkCZwiMPjDD
rKNpoSidnQkzmnHev5xuDSjz9Mk0/6tF4iMvd6Tc6yz1dOAElx+yGMlFcaNEPFqg
D2kEM/5FJwoxRxBkQiHpTsPfbMr7BQJTrGLz2c1JnLZl1uWqQuCL4+WP0QRNu06P
ljq7RVbj8ecOwZkQ7O68shxQvMtTlgBi80OSTg+o9Q8807kSATFUyvLh+a7dUERC
Si+qAslaSMqTudmXxj251KpFHq+lscBzVkxALhPeugWbYxG2Mxh1PN9GVugnW0pi
lJbcbFApAgMBAAECggEBAIHDyokPkeiFoD4ZjtBihjpOsSvuADghRr4hzeWZAZoR
xjA06roWfQz54ZPF9qR0LEcc9JtU8tpFVFY0jmRQWMXb11IFomclJVkGL3IBvwC9
T0i9sURPqaxb+1tp/VvBZhcEOmyKNgxHNF7Z486196kjVNMk3NHjK7LmBcCgFHZI
Nia90NcSukpaLkOJnYt43sZ2Rjtfd8kuTzYjTyjchhnjz86qbOrm5IY/d2yJxS+M
znb71R/1XWGXLMiNUZF0dsrMFuCCCYnlUSxc+50W1N0M6Ioeaqe1MFLU9UATky3/
cOy8FtEZvDoflAesM8qV+T0nxcgM3f1UHk4HYk41oIECgYEA7OkYs9dyaJ5IBzKG
PuCeN/qfvYi0HTIZYH3TWZHb+3BjDKblJr7HrSsbJBdyUGjlMyO2xN//gCqoN43Z
7ONxIfh9GIRSdt5V9ZoenrOiNvhAoy3vitdM5/ouwBJxICMlpS4s7gM3aq+7Shoj
CUc/RQBAFr0FPkfgVdqpQKygTnECgYEA4EN/43vRJaay0pzNovnod132U/ybTJ/O
7w9XGolxQqvtzZoOvaTRk2CsLn63l8Ppu/loPRM2rkl/9nQkr27Hld2YTi0xTgy9
4CrSPBdHkFDXJULGGSkrQss6okPdnTHG5SXUrMEeIt1+GobArTj7iVF1VwdDPoqS
ND9QWVG26TkCgYEA2yHkeny+02wMfbPLHp/PWUIVvU+UIikz9d+MvZ2/13wl8g7x
iHwQ3+kuSpzxXNUZo8rWBJaYkylhvTkVKRtbiqt4slO6nz6aTfmHdw367lOEHiug
FVF+TlhII9srDinUaUwjvOf2u1TerPUuESf4qs9HeIDQN8JuC5uc0DicctECgYBI
CCY5sPlaeJKTZ139bPun63xFOavADsxuqKS3l1HTslltYoA9lYTjK3fibz0U+A5J
HDDI/TThAiahyGhIGPLuRgC3i3h8s0cBi39/YZLQ3cZc53eteTW1/ITWvame5fAW
hfIrktPVKwNoDcQxX04bqxhfXavRmLyhH3z1U3PGsQKBgFH2EEJ175cNHR4Fm21R
K6YTJQsIysBBuhnyUv8IJMqqjsJwY42IzD4Gp/MM+jUd+eUzFcQHYMoMJFIycqCK
2KDWJ2jIqdFjXDjZoG/aL5zls0uomCefuOHMklFN45iFSkWgOOCdNXAccCl0VlxU
18ij8ZttH5sZxogzQl1JXjyX
-----END PRIVATE KEY-----
Loading