removed OPENBLAS_NUM_THREADS default from Malt.jl, fixes #233

[ajinkya-k]

See discussion in #233

[ajinkya-k]

@MichaelHatherly this should be enough to fix #233 right?

[MichaelHatherly]

this should be enough to fix #233 right?

Thanks @ajinkya-k, so the most important part of #233 in my mind is:

We can change the behaviour if it can be confirmed that it won't result in confusing errors for users.

It's better if users' notebooks don't fail, but may need to set the number of threads to something more than 1 if they need to increase performance, rather than failing for potentially hard to debug reasons and those users being required to add this env var to every single one of their notebooks to avoid errors.

If it can be confirmed that changing this setting doesn't introduce hard to debug errors for any users then we can. Is that something you have already done and can confirm?

[MichaelHatherly]

@ajinkya-k bump?

[ajinkya-k]

@MichaelHatherly I’m not sure how to test this. Feel free to close it now PR if you think its half cooked

[MichaelHatherly]

@ajinkya-k I would say that the fix for this is tightly coupled to the fix for #277. Since an OOM on Windows is going to terminate the process, which results in the error described in #277. Once that one is resolved then I think we'll be in a better position to say whether altering the OPENBLAS default is doable without confusing users, I think it is likely that we'll be able to change the default. Note that fixing #277 isn't going to be particularly simple or happening that soon given other priorities.

[ajinkya-k]

No worries! Thanks for the update!