Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed OPENBLAS_NUM_THREADS default from Malt.jl, fixes #233 #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajinkya-k
Copy link

See discussion in #233

@ajinkya-k
Copy link
Author

@MichaelHatherly this should be enough to fix #233 right?

@MichaelHatherly
Copy link
Collaborator

this should be enough to fix #233 right?

Thanks @ajinkya-k, so the most important part of #233 in my mind is:

We can change the behaviour if it can be confirmed that it won't result in confusing errors for users.

It's better if users' notebooks don't fail, but may need to set the number of threads to something more than 1 if they need to increase performance, rather than failing for potentially hard to debug reasons and those users being required to add this env var to every single one of their notebooks to avoid errors.

If it can be confirmed that changing this setting doesn't introduce hard to debug errors for any users then we can. Is that something you have already done and can confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants