Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Makie and fix tests #281

Merged
merged 5 commits into from
Mar 13, 2025
Merged

Unpin Makie and fix tests #281

merged 5 commits into from
Mar 13, 2025

Conversation

jkrumbiegel
Copy link
Collaborator

Instead of just changing all the tested metadata values to the same values given figure size (because they don't reflect dpi) I've added tests for both logical and real image size everywhere.

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.09%. Comparing base (a2ce1e4) to head (ee30627).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   32.07%   32.09%   +0.02%     
==========================================
  Files          57       57              
  Lines        2672     2673       +1     
==========================================
+ Hits          857      858       +1     
  Misses       1815     1815              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MichaelHatherly MichaelHatherly linked an issue Mar 13, 2025 that may be closed by this pull request
@jkrumbiegel jkrumbiegel merged commit 53ce1e1 into main Mar 13, 2025
11 of 12 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/unpin-makie branch March 13, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin Makie in tests
2 participants