Skip to content

fix(research): fix AttributeError in suggest_objectives_from_chains #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PurpleCHOIms merged 1 commit into from
May 9, 2026
+7 −17
Merged

fix(research): fix AttributeError in suggest_objectives_from_chains #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions decepticon/tools/research/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,29 +1627,19 @@ def suggest_objectives_from_chains(

for idx, chain in enumerate(ranked[:top_k], start=1):
chain_score = critical_path_score(chain)
mitre: list[str] = []
highest = Severity.INFO

for step in chain.steps:
step_mitre = step.node.props.get("mitre")
if isinstance(step_mitre, list):
mitre.extend([m for m in step_mitre if isinstance(m, str)])
sev = _severity_from_string(step.node.props.get("severity"))
if sev in {Severity.CRITICAL, Severity.HIGH}:
highest = sev

phase = "initial-access"
if any(step.node.kind in {NodeKind.CREDENTIAL, NodeKind.SECRET} for step in chain.steps):
if any(step.node_kind in {NodeKind.CREDENTIAL, NodeKind.SECRET} for step in chain.steps):
phase = "post-exploit"
elif (
"admin" in chain.crown_jewel.label.lower()
or "domain" in chain.crown_jewel.label.lower()
"admin" in chain.crown_jewel_label.lower()
or "domain" in chain.crown_jewel_label.lower()
):
phase = "post-exploit"

title = f"Exploit chain {idx}: {chain.entrypoint.label} -> {chain.crown_jewel.label}"
title = f"Exploit chain {idx}: {chain.entrypoint_label} -> {chain.crown_jewel_label}"
acceptance = [
f"Demonstrate path from {chain.entrypoint.label} to {chain.crown_jewel.label}.",
f"Demonstrate path from {chain.entrypoint_label} to {chain.crown_jewel_label}.",
"Capture evidence for each hop (commands, outputs, and impacted asset IDs).",
"Validate the highest-risk step with PoC evidence or explain why blocked.",
]
Expand All @@ -1660,8 +1650,8 @@ def suggest_objectives_from_chains(
"title": title,
"description": chain.summary(),
"acceptance_criteria": acceptance,
"mitre": sorted(set(mitre)),
"opsec": "careful" if highest in {Severity.HIGH, Severity.CRITICAL} else "standard",
"mitre": [],
"opsec": "standard",
"notes": {
"chain_total_cost": chain.total_cost,
"chain_score": chain_score,
Expand Down