fix(llm): use Any instead of object for kwargs type in _build_litellm_model#179
Merged
PurpleCHOIms merged 1 commit intoPurpleAILAB:mainfrom May 9, 2026
Merged
Conversation
…_model dict[str, object] caused ~80 pyright warnings when the kwargs dict was unpacked into ChatOpenAI/ChatAnthropic constructors, burying real type errors in the factory. Any is already imported and is the correct type for a heterogeneous kwargs accumulator. Closes PurpleAILAB#162
PurpleCHOIms
approved these changes
May 9, 2026
Member
PurpleCHOIms
left a comment
PurpleCHOIms
left a comment
There was a problem hiding this comment.
Type-only fix verified: Any already imported, kwargs dict legitimately heterogeneous (SecretStr/int/bool/dict), no runtime impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dict[str, object]→dict[str, Any]for thekwargsaccumulator inLLMFactory._build_litellm_model()(decepticon/llm/factory.py:702)Anyis already imported; this is a one-line changeArgument of type "object" cannot be assigned to parameter "model" of type "str"that were drowning out real type errors in the factory moduleTest plan
make lintpasses on the changed file (ruff check+ruff format)make test-localpasses (no behavioural change — this is a type annotation only)object→ constructor-param warnings infactory.pyCloses #162