feat(remote_agent): add dispatch guard for queue load#80
Open
PiyushDatta wants to merge 1 commit intomainfrom
Open
feat(remote_agent): add dispatch guard for queue load#80PiyushDatta wants to merge 1 commit intomainfrom
PiyushDatta wants to merge 1 commit intomainfrom
Conversation
- introduce DispatchGuardConfig/env helpers in apps/remotebuddy/src/autonomous_engine.ts to bound queue latency thresholds - evaluate queue and idle telemetry via evaluateDispatchGuardState and decideDispatchGuardAction to throttle, reroute, or allow - fetch /system/status metrics, log guard decisions, and block objectives with guardBlockReason when pressure stays high - reroute selections using pickQueueHealthRerouteCandidate and flush guard metrics/logs through CommunicationManager hooks - add vitest suite to autonomous_engine.ts covering guard decisions, reroute selection, and metrics emission Tests: - not run
Collaborator
Author
ReviewAgent: Changes Rejected (score 7.8/10)Verdict: The dispatch guard implementation is well-structured and thoroughly unit-tested, but it contains a policy-breaking fallback that can bypass protection under queue pressure. Issues:
This PR has been re-queued for automated fixes. A worker will address the issues above. |
Collaborator
Author
ReviewAgent: Changes Rejected (score 7.9/10)Verdict: The dispatch guard feature is thoughtfully implemented with strong unit coverage, but it contains a policy bypass and operational resilience gaps that prevent production-ready confidence. Issues:
This PR has been re-queued for automated fixes. A worker will address the issues above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ce445545-27c9-4d64-ae0c-5ebef047b619tomain_agents.20909f6ba7ff04dec7ebcd604c7f3391a623946cfromrefs/pushpals/agent/workerpal-d4f80a1c/ce445545-27c9-4d64-ae0c-5ebef047b619.workerpal-d4f80a1creported: Executed task and modified 1 file(s) (quality gate soft-pass after 4 auto-revision attempt(s))Implement an adaptive dispatch guard in apps/remotebuddy/src/autonomous_engine.ts that ingests queue telemetry (moving p95 latency, worker idle counts), throttles or reroutes delegation when pressure exceeds configured thresholds, and em...Motivation / Context
Planned Scope
apps/remotebuddy/src/autonomous_engine.tsPlanned Validation
Changes
apps/remotebuddy/src/autonomous_engine.tsTesting / Validation
Impact / Risk
SourceControlManager Note
fix(repo): Implement an adaptive dispatch guard in apps/remotebuddy/src/autonomous_engine.ts that ingest...Checklist
Tests added/updated where appropriate
Validation commands run (or noted as not run)
Docs/comments updated if needed
No sensitive data (secrets/tokens) committed
Agent branch:
agent/workerpal-d4f80a1c/ce445545-27c9-4d64-ae0c-5ebef047b619Completion ref:
refs/pushpals/agent/workerpal-d4f80a1c/ce445545-27c9-4d64-ae0c-5ebef047b619Commit:
20909f6ba7ff04dec7ebcd604c7f3391a623946cCompletion ID:
073d0178-2e87-4c4c-8095-4300cc231b82