Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Cython extension class properties to decorator syntax part 1 of 4 #1287

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

JoeSchiff
Copy link
Contributor

"Showing 24 changed files with 907 additions and 843 deletions."
I doubt that you want this all in one PR, so I broke it up into more manageable chunks.

We currently use a legacy syntax for defining properties in an extension class which has been deprecated since ~2016:
https://cython.readthedocs.io/en/stable/src/userguide/extension_types.html#properties

Switching to the new syntax required moving the property docstrings. Previously, the docstring was placed on the line below the property keyword. However, using the new syntax there can not be anything between the decorator and the def statement, so the docstring was moved to below the def statement.

@WyattBlue
Copy link
Member

Thank you

@WyattBlue WyattBlue merged commit 6bc9621 into PyAV-Org:main Feb 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants