Convert Cython extension class properties to decorator syntax part 1 of 4 #1287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Showing 24 changed files with 907 additions and 843 deletions."
I doubt that you want this all in one PR, so I broke it up into more manageable chunks.
We currently use a legacy syntax for defining properties in an extension class which has been deprecated since ~2016:
https://cython.readthedocs.io/en/stable/src/userguide/extension_types.html#properties
Switching to the new syntax required moving the property docstrings. Previously, the docstring was placed on the line below the
property
keyword. However, using the new syntax there can not be anything between the decorator and thedef
statement, so the docstring was moved to below the def statement.