Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert deprecated cython extension class properties to new syntax part 3 #1289

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

JoeSchiff
Copy link
Contributor

WyattBlue, I saw a note you made here:
https://github.com/PyAV-Org/PyAV/wiki/TODO-general
"Convert properties to decorator syntax. This will also allow doctest to run on them."

Could you explain what you meant by this? Is doctest incompatible with the old syntax?

@WyattBlue
Copy link
Member

WyattBlue, I saw a note you made here:
https://github.com/PyAV-Org/PyAV/wiki/TODO-general

Mike Boers wrote that, actually. I don't think those comments are relevant anymore

@WyattBlue WyattBlue merged commit 4407056 into PyAV-Org:main Feb 24, 2024
18 checks passed
@mikeboers
Copy link
Member

I don’t read everything that goes on here anymore (duh), but when the notification looks like that I can’t refuse, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants