test: delete jax-using unit tests (moved to autofit_workspace_test)#1247
Merged
test: delete jax-using unit tests (moved to autofit_workspace_test)#1247
Conversation
Removes the source unit tests that imported jax — completes the prior work (commits 9558988, 3ef0d46, 1692c8e, 1caf713) which made jax optional in the library, gated jax tests with importorskip, and moved 5 Fitness/dispatch assertions to autofit_workspace_test. Now also removes: - test_autofit/jax/{test_pytrees,test_enable_pytrees,test_jit}.py + empty __init__.py — moved to scripts/jax_assertions/{pytrees,enable_pytrees}.py in autofit_workspace_test (test_jit.py was dead — all tests commented). - test_autofit/graphical/functionality/test_nested.py — moved to scripts/jax_assertions/nested.py. - test_autofit/graphical/functionality/test_jacobians.py — dead code, all tests commented. - conftest.py: simplified collect_ignore_glob block (no more jax-targeted ignore patterns since the targets are gone). No library code changes. Local pytest: 1225 passed. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes source unit tests that imported jax. Completes the prior chat's work (
9558988b0library jax-optional +3ef0d4662conftest cleanup +1caf7135 assertions moved to workspace_test) by deleting the now-redundant test sources.Changes
test_autofit/jax/{test_pytrees,test_enable_pytrees,test_jit}.py+ empty__init__.py. Tests moved toautofit_workspace_test/scripts/jax_assertions/{pytrees,enable_pytrees}.py. (test_jit.pywas dead — all tests commented.)test_autofit/graphical/functionality/test_nested.py. Moved toautofit_workspace_test/scripts/jax_assertions/nested.py.test_autofit/graphical/functionality/test_jacobians.py. Dead code — all tests commented out long ago.test_autofit/conftest.py: drop the now-pointlesscollect_ignore_globblock (its only targets —jax/*.pyandtest_jacobians.py— are gone). Drop theimportlib.utilimport that was only used there.No library code changes.
Merge dependency
Depends on autofit_workspace_test#21 merging first, so the moved assertions exist on main before the source tests are removed.
Test plan