fix: populate NUTS samples_info keys under test-mode bypass#1260
Merged
fix: populate NUTS samples_info keys under test-mode bypass#1260
Conversation
`PYAUTO_TEST_MODE=2` skips the sampler in `_fit_bypass_test_mode`, producing a samples_info stub with only `total_iterations`, `time`, and `log_evidence`. Tutorial and downstream code that reads NUTS diagnostics (`ess_min`, `num_samples`, `mean_acceptance`, `n_divergent`, `n_logl_evals`) crashed with `KeyError`. Add a `_test_mode_samples_info()` hook on `AbstractSearch`, merged into the bypass `samples_info`. Override in `BlackJAXNUTS` to return the diagnostic keys with NaN/0 placeholders — bypass mode never ran the sampler, so honest empties propagate to the tutorial print. Fixes the `autofit_workspace/scripts/searches/mcmc.py` smoke test. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_test_mode_samples_info()hook onAbstractSearchso subclasses can declare which diagnostic keys theirsamples_info_from()would normally populate. Hook return is merged into the bypasssamples_infoso downstream code reading per-sampler diagnostics doesn'tKeyError.BlackJAXNUTSto returnnum_warmup,num_samples,num_chains,ess_min,ess_per_param,mean_acceptance,n_divergent,n_logl_evals,total_walkers,total_stepswith NaN/0 placeholders.autofit_workspace/scripts/searches/mcmc.pysmoke (NUTS section) underPYAUTO_TEST_MODE=2.Test plan
PYAUTO_TEST_MODE=2 python autofit_workspace/scripts/searches/mcmc.pyruns to completion, printsESS (min over dims): nan / 0etc.mainafter merge🤖 Generated with Claude Code