fix: xp-gate jax.scipy.special.factorial in shapelets/exponential.py#385
Merged
Conversation
The unconditional `from jax.scipy.special import factorial` inside ShapeletExponential.image_2d_from broke library CI with ModuleNotFoundError when JAX is absent. Sibling modules cartesian.py and polar.py already gate this import with `if xp is np`; this applies the same pattern to exponential.py. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autogalaxy/profiles/light/standard/shapelets/exponential.py:90did an unconditionalfrom jax.scipy.special import factorialinsideimage_2d_from, breaking library CI withModuleNotFoundError: No module named 'jax'(failing test:test_autogalaxy/profiles/light/shapelets/test_exponential.py::test__image_2d_from__elliptical__ell_comps_0p1_0p2__correct_values).if xp is npgate that already exists in sibling modulescartesian.py(lines 104-108) andpolar.py(lines 152-157). NumPy path usesscipy.special.factorial, JAX path usesjax.scipy.special.factorial.Test plan
pytest test_autogalaxy/profiles/light/shapelets/test_exponential.py— 4 passed.🤖 Generated with Claude Code