Skip to content

feat: SimulatorImaging.via_galaxies_from auto-default xp from parent use_jax #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
May 24, 2026
Merged

feat: SimulatorImaging.via_galaxies_from auto-default xp from parent use_jax #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions autogalaxy/imaging/simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

class SimulatorImaging(aa.SimulatorImaging):
def via_galaxies_from(
self, galaxies: List[Galaxy], grid: aa.type.Grid2DLike
self, galaxies: List[Galaxy], grid: aa.type.Grid2DLike, xp=None
) -> aa.Imaging:
"""
Simulate an `Imaging` dataset from an input list of `Galaxy` objects and a 2D grid of (y,x) coordinates.
Expand Down Expand Up @@ -48,6 +48,9 @@ def via_galaxies_from(
to generate the image of the galaxies.
"""

if xp is None:
xp = self._xp

galaxies = Galaxies(galaxies=galaxies)

for galaxy in galaxies:
Expand All @@ -59,14 +62,14 @@ def via_galaxies_from(
)

image = galaxies.padded_image_2d_from(
grid=grid, psf_shape_2d=self.psf.kernel.shape_native
grid=grid, psf_shape_2d=self.psf.kernel.shape_native, xp=xp
)

over_sample_size = grid.over_sample_size.resized_from(
new_shape=image.shape_native, mask_pad_value=1
)

dataset = self.via_image_from(image=image, over_sample_size=over_sample_size)
dataset = self.via_image_from(image=image, over_sample_size=over_sample_size, xp=xp)

return dataset.trimmed_after_convolution_from(
kernel_shape=self.psf.kernel.shape_native
Expand Down
Loading