fix: add xp=np to convergence_func across all mass profiles#457
Merged
Conversation
Add missing xp=np parameter to convergence_func in 5 locations: MassProfile base class, ExternalShear, ExternalPotential, MassSheet, and SersicGradient. This allows MGEDecomposer.decompose_convergence_via_mge to call convergence_func(xp=xp) without TypeError. Fixes #456. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
xp=npparameter toconvergence_funcin 5 locations where it was absent:MassProfilebase class,ExternalShear,ExternalPotential,MassSheet, andSersicGradient. This allowsMGEDecomposer.decompose_convergence_via_mgeto callconvergence_func(xp=xp)without TypeError, unblocking MGE-based potential computation for PowerLawBroken, dPIE, and SersicGradient profiles. Fixes #456.API Changes
Added
xp=npkeyword to 5convergence_funcsignatures. Default isnpso existing callers are unaffected.Test Plan
pytest test_autogalaxy/profiles/mass/— 406 passed, 0 failed🤖 Generated with Claude Code