Conversation
…e.py
The Simple-Loading section reloaded the saved dataset.fits with
data_hdu=0, noise_map_hdu=1, psf_hdu=2, but the visualizer writes the
file as MASK at HDU 0 and the data/noise_map/psf triplet starting at
HDU 1. With the wrong shift, psf_hdu=2 pulled the 100x100 noise map
and the Convolver constructor rejected it with KernelException
("Convolver must be odd"), crashing start_here.py. Shift indices by
one so the kwargs match the visualizer's HDU layout.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix HDU indices in the
dataset.fitsreload block ofscripts/guides/results/start_here.py. The Simple-Loading section was passingdata_hdu=0, noise_map_hdu=1, psf_hdu=2, but the visualizer writesdataset.fitswith MASK at HDU 0 and the data / noise_map / psf triplet at HDUs 1 / 2 / 3. The off-by-one madepsf_hdu=2pull the 100×100 noise map, which theConvolverrejected withKernelException: "Convolver Convolver must be odd", crashing the script end-to-end.Scripts Changed
scripts/guides/results/start_here.py— bumpeddata_hdu0→1,noise_map_hdu1→2,psf_hdu2→3 in the FITS-reload block (lines 233–235) so the kwargs match the visualizer's actual HDU layout:MASK, DATA, NOISE_MAP, PSF, OVER_SAMPLE_SIZE_LP, OVER_SAMPLE_SIZE_PIXELIZATION.Test Plan
PYAUTO_TEST_MODE=1 python scripts/guides/results/start_here.pyruns to completion from a cleanoutput/results_folder(clean-fit case).from_fits).aggregator/{galaxies_fit,samples,samples_via_aggregator}.pystill pass.scripts/check_sizes.shreports "all scripts within size tolerance".🤖 Generated with Claude Code