fix: unpark ellipse example scripts after JAX refactor#73
Merged
Conversation
The five `scripts/ellipse/*` examples were parked on 2026-04-24 in config/build/no_run.yaml pending the ellipse JAX refactor in PyAutoGalaxy. That refactor has now shipped (PyAutoGalaxy #408 / #410 / #412, all merged 2026-05-14), and all five scripts (simulator, fit, modeling, multipoles, database) now pass under PYAUTO_TEST_MODE=2. Also patch a leftover `path.exists(...)` / `os.remove(...)` in scripts/ellipse/database.py (the `os.path -> pathlib` refactor removed the `path` import but missed two call sites) with `Path(...).exists()` and `.unlink()`. Paired with PyAutoFit #1270 (Drawer.from_dict fix surfaced by the aggregator scrape in database.py). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reactivate the five
scripts/ellipse/*example scripts that were parked on 2026-04-24 inconfig/build/no_run.yamlpending the ellipse JAX refactor in PyAutoGalaxy. That refactor has now shipped (PyAutoGalaxy #408ellipse-xp, #410fit-ellipse-jax, #412analysis-ellipse-jax, all merged 2026-05-14), and all five scripts (simulator,fit,modeling,multipoles,database) now pass cleanly underPYAUTO_TEST_MODE=2.Also patches a leftover
path.exists(...)/os.remove(...)pair inscripts/ellipse/database.py— the prioros.path → pathlibrefactor removed thepath(i.e.os.path) import but missed two call sites, leaving the script broken on import. Replaced with the pathlib idiom(Path(...) / name).exists()and.unlink().Surfaced during this work, and shipped as a paired upstream fix: PyAutoFit #1270 (
Drawer.__init__from_dictround-trip crash on duplicatenumber_of_cores), which the aggregator scrape indatabase.pywas hitting on every saved Drawer fit.Scripts Changed
config/build/no_run.yaml— remove the fiveellipse/{simulator,fit,modeling,multipoles,database}NEEDS_FIX 2026-04-24 entriesscripts/ellipse/database.py— replace 2×path.exists(...)/os.remove(...)(leftover from theos.path → pathlibrefactor;pathis no longer imported) withPath(...).exists()/.unlink()Upstream PR
fix: dedupe number_of_cores in Drawer for from_dict round-trip(paired Drawer fix thatdatabase.pyexposed during verification)Test Plan
PYAUTO_TEST_MODE=2end-to-end in the worktreedatabase.pyaggregator scrape offit_allDrawer outputs now succeeds with PyAutoFit #1270 applied🤖 Generated with Claude Code