Skip to content

fix: unpark ellipse example scripts after JAX refactor#73

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/unpark-ellipse-scripts
May 15, 2026
Merged

fix: unpark ellipse example scripts after JAX refactor#73
Jammy2211 merged 1 commit into
mainfrom
feature/unpark-ellipse-scripts

Conversation

@Jammy2211
Copy link
Copy Markdown
Collaborator

Summary

Reactivate the five scripts/ellipse/* example scripts that were parked on 2026-04-24 in config/build/no_run.yaml pending the ellipse JAX refactor in PyAutoGalaxy. That refactor has now shipped (PyAutoGalaxy #408 ellipse-xp, #410 fit-ellipse-jax, #412 analysis-ellipse-jax, all merged 2026-05-14), and all five scripts (simulator, fit, modeling, multipoles, database) now pass cleanly under PYAUTO_TEST_MODE=2.

Also patches a leftover path.exists(...) / os.remove(...) pair in scripts/ellipse/database.py — the prior os.path → pathlib refactor removed the path (i.e. os.path) import but missed two call sites, leaving the script broken on import. Replaced with the pathlib idiom (Path(...) / name).exists() and .unlink().

Surfaced during this work, and shipped as a paired upstream fix: PyAutoFit #1270 (Drawer.__init__ from_dict round-trip crash on duplicate number_of_cores), which the aggregator scrape in database.py was hitting on every saved Drawer fit.

Scripts Changed

  • config/build/no_run.yaml — remove the five ellipse/{simulator,fit,modeling,multipoles,database} NEEDS_FIX 2026-04-24 entries
  • scripts/ellipse/database.py — replace 2× path.exists(...) / os.remove(...) (leftover from the os.path → pathlib refactor; path is no longer imported) with Path(...).exists() / .unlink()

Upstream PR

Test Plan

  • All five ellipse scripts run cleanly under PYAUTO_TEST_MODE=2 end-to-end in the worktree
  • database.py aggregator scrape of fit_all Drawer outputs now succeeds with PyAutoFit #1270 applied
  • Smoke tests pass for autogalaxy_workspace

🤖 Generated with Claude Code

The five `scripts/ellipse/*` examples were parked on 2026-04-24 in
config/build/no_run.yaml pending the ellipse JAX refactor in PyAutoGalaxy.
That refactor has now shipped (PyAutoGalaxy #408 / #410 / #412, all merged
2026-05-14), and all five scripts (simulator, fit, modeling, multipoles,
database) now pass under PYAUTO_TEST_MODE=2.

Also patch a leftover `path.exists(...)` / `os.remove(...)` in
scripts/ellipse/database.py (the `os.path -> pathlib` refactor removed the
`path` import but missed two call sites) with `Path(...).exists()` and
`.unlink()`. Paired with PyAutoFit #1270 (Drawer.from_dict fix surfaced by
the aggregator scrape in database.py).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Jammy2211 Jammy2211 added the pending-release PR queued for the next release build label May 15, 2026
@Jammy2211 Jammy2211 merged commit 97277d6 into main May 15, 2026
4 of 6 checks passed
@Jammy2211 Jammy2211 deleted the feature/unpark-ellipse-scripts branch May 15, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-release PR queued for the next release build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant