Skip to content

fix: disable positions-likelihood exception for pix/delaunay profiling #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
May 28, 2026
Merged

fix: disable positions-likelihood exception for pix/delaunay profiling #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions searches/_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,12 @@ def _build_analysis(
use_mixed_precision: bool,
adapt_images: Optional[al.AdaptImages],
) -> Any:
# Pixelization / Delaunay analyses normally require ``positions_likelihood_list``
# to guard against the demagnified-source systematic. For pure profiling we
# don't care about solution quality — we're measuring sampler + likelihood
# cost — so disable the check rather than wire up truth-position plumbing.
raise_positions_exc = model_type not in ("pixelization", "delaunay")

if dataset_class == "imaging":
return al.AnalysisImaging(
dataset=dataset,
Expand All @@ -493,6 +499,7 @@ def _build_analysis(
use_border_relocator=model_type in ("pixelization", "delaunay"),
use_mixed_precision=use_mixed_precision,
),
raise_inversion_positions_likelihood_exception=raise_positions_exc,
use_jax=use_jax,
)
if dataset_class in ("interferometer", "datacube"):
Expand All @@ -503,6 +510,7 @@ def _build_analysis(
use_border_relocator=model_type in ("pixelization", "delaunay"),
use_mixed_precision=use_mixed_precision,
),
raise_inversion_positions_likelihood_exception=raise_positions_exc,
use_jax=use_jax,
)
if dataset_class == "point_source":
Expand Down
Loading