fix: drop PYAUTO_SMALL_DATASETS workaround in group simulators#102
Merged
fix: drop PYAUTO_SMALL_DATASETS workaround in group simulators#102
Conversation
PointSolver.solve now short-circuits to [(1.0, 0.0), (0.0, 1.0)] when PYAUTO_SMALL_DATASETS=1 (PyAutoLens PR #479), so the env-var pop/restore dance around solver.solve is no longer needed. Removes 21 lines across: - scripts/group/simulator.py - scripts/group/features/multi_gaussian_expansion/simulator.py - scripts/group/features/no_lens_light/simulator.py Refs #477.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that
PointSolver.solveshort-circuits to a fixed pair of positions whenPYAUTO_SMALL_DATASETS=1(PyAutoLabs/PyAutoLens#479), the three group simulator scripts no longer need to pop the env var aroundsolver.solveand restore it afterward. This PR deletes that workaround.Refs PyAutoLabs/PyAutoLens#477.
Scripts Changed
scripts/group/simulator.py— removedimport os,small_datasets = os.environ.pop(...), and the restore block aroundsolver.solve.scripts/group/features/multi_gaussian_expansion/simulator.py— same cleanup.scripts/group/features/no_lens_light/simulator.py— same cleanup.Net change: -21 lines, no behavior change in production runs (the workaround was only relevant under
PYAUTO_SMALL_DATASETS=1, which is now handled inside the solver itself).Upstream PR
PyAutoLabs/PyAutoLens#479
Test Plan
/smoke_testpasses for autolens_workspace🤖 Generated with Claude Code