chore: park double_einstein_ring/slam as NEEDS_FIX (Cluster H)#134
Merged
chore: park double_einstein_ring/slam as NEEDS_FIX (Cluster H)#134
Conversation
scripts/imaging/features/advanced/double_einstein_ring/slam.py crashes under PYAUTO_TEST_MODE=2 with autofit.exc.FitException at PyAutoLens/autolens/imaging/model/analysis.py:84. Investigation revealed a cascade: Adapt regularization (used by the SLaM pixelization phases) requires per-galaxy adapt_data that the synthetic samples_summary produced by bypass mode does not carry. The same Mapper.pixel_signals_from None-deref is reachable from multiple inversion entry points (log_likelihood, post-fit result.subtracted_signal_to_noise_map_galaxy_dict, etc.), so patching one site only unblocks the next. Even after a defensive FitException-tolerance patch in _fit_bypass_test_mode, the script fails downstream when the next SLaM phase derives adapt_images from the synthetic result. Fixing this end-to-end requires either defensively pretending Adapt regularization works without adapt_data (silent semantic change — unsafe) or restructuring the SLaM bypass to construct valid adapt_data (large refactor). Park alongside imaging/features/pixelization/slam (NEEDS_FIX 2026-04-10) which has the same root cause. A follow-up issue will track the broader bypass-mode + Adapt incompatibility. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/imaging/features/advanced/double_einstein_ring/slam.pycrashes underPYAUTO_TEST_MODE=2withautofit.exc.FitExceptionatanalysis.py:84. Investigation traced the failure to a structural incompatibility between bypass mode andAdaptregularization:Adapt.regularization_weights_from→Mapper.pixel_signals_fromdoesself.adapt_data.array, which isNoneunder bypass.None-deref is reachable from multiple inversion entry points (likelihood evaluation, post-fitresult.subtracted_signal_to_noise_map_galaxy_dict, etc.), so patching one site only unblocks the next._fit_bypass_test_mode(which I drafted and then rolled back), the script fails downstream when the next SLaM phase derivesadapt_imagesfrom the synthetic samples_summary.Adaptworks withoutadapt_data(silent semantic change — unsafe) or (b) restructuring the SLaM bypass to construct validadapt_data(large refactor).This was Cluster H of the recent release-prep triage. Parking alongside
imaging/features/pixelization/slam # NEEDS_FIX 2026-04-10which has the same root cause and has been parked for ~26 days.Files Changed
config/build/no_run.yaml— one new# NEEDS_FIX 2026-05-07entry forimaging/features/advanced/double_einstein_ring/slam. Sibling of the existingimaging/features/pixelization/slamentry.Test Plan
🤖 Generated with Claude Code