refactor: drop xp=jnp from PointSolver.for_grid call sites#81
Merged
Conversation
Following PyAutoLens #469, PointSolver.for_grid no longer accepts xp=. Strip the kwarg from all 6 point-source usages; remove the now-dead "Hacky way to use JAX PointSolver" dual-solver pattern from point_source/modeling.py and point_source/start_here.py so that a single solver is reused for the AnalysisPoint(..., use_jax=True) path. Co-Authored-By: Claude Opus 4.7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all
PointSolver.for_grid(xp=jnp)call sites after the ergonomic refactor in PyAutoLabs/PyAutoLens#469. With the library change, a single solver works for both numpy and JAX paths; the "Hacky way to use JAX PointSolver, fix soon" dual-solver workaround is no longer needed.Scripts Changed
scripts/cluster/modeling.py— dropxp=jnpfromPointSolver.for_grid, remove unusedjnpimportscripts/guides/modeling/advanced/graphical.py— dropxp=jnpfromPointSolver.for_grid, remove unusedjnpimportscripts/point_source/features/fluxes.py— dropxp=jnpfromPointSolver.for_grid, remove unusedjnpimportscripts/point_source/features/time_delays.py— dropxp=jnpfromPointSolver.for_grid, remove unusedjnpimportscripts/point_source/modeling.py— remove dual-solver "Hacky way to use JAX PointSolver" block;AnalysisPoint(use_jax=True)now reuses the singlesolverscripts/point_source/start_here.py— remove dual-solver block as aboveUpstream PR
PyAutoLabs/PyAutoLens#469
Test Plan
🤖 Generated with Claude Code