Skip to content

config(env_vars): repair FAST_PLOTS coverage for visualization scripts#107

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/fast-plots-env-coverage
May 20, 2026
Merged

config(env_vars): repair FAST_PLOTS coverage for visualization scripts#107
Jammy2211 merged 1 commit into
mainfrom
feature/fast-plots-env-coverage

Conversation

@Jammy2211
Copy link
Copy Markdown
Collaborator

Summary

Several env_vars.yaml override entries were missing PYAUTO_FAST_PLOTS from their unset: list, so the build server kept PYAUTO_FAST_PLOTS=1 set even for the visualization scripts that explicitly assert PNGs land on disk. PYAUTO_FAST_PLOTS=1 short-circuits subplot_save / save_figure in PyAutoArray — no PNG ever written, assertions fail with "fit.png was not produced" / "dataset.png missing" (triage Cluster A, plus the parked 40d-old imaging/visualization NEEDS_FIX entry).

This PR closes the coverage gap for every affected script and adds a new override for point_source/visualization.py (which had no entry at all).

Configs Changed

  • config/build/env_vars.yaml:
    • Updated pattern-convention header comment to document .py-anchored patterns.
    • imaging/visualization.py: appended PYAUTO_FAST_PLOTS to unset: (was only unsetting PYAUTO_SMALL_DATASETS).
    • interferometer/visualization.py: appended PYAUTO_SMALL_DATASETS to unset: — script loads FITS at full res with an explicit (100, 100) shape_native mask, so the 15×15 cap mismatches even when shape_native is explicit.
    • imaging/visualization_jax: appended PYAUTO_FAST_PLOTS to unset:.
    • point_source/visualization_jax: appended PYAUTO_FAST_PLOTS to unset:.
    • Added new override for point_source/visualization.pyunset: [PYAUTO_FAST_PLOTS] (JSON dataset, no FITS, no mask — PYAUTO_FAST_PLOTS alone is sufficient).

Upstream PR

PyAutoBuild #91 — depends on its _pattern_matches fix to make the existing imaging/visualization.py and interferometer/visualization.py overrides fire (previously dead because the matcher stripped .py from the path before substring matching).

Test Plan

  • End-to-end smoke under autobuild-resolved env (full build_env_for_script pipeline, with PyAutoBuild feat: autolens point_source JAX visualization scripts #91 applied): all 5 affected scripts pass — imaging 64.1s, interferometer 69.5s, point_source 20.0s, point_source_jax 41.6s, imaging_jax 123.8s.
  • /smoke_test autolens_test runs cleanly (visualization scripts are commented out in smoke_tests.txt for an unrelated bypass-mode issue, so this PR is not directly exercised by smoke).

Next triage cluster regen should clear the autolens entries of Cluster A and the parked imaging/visualization NEEDS_FIX.

🤖 Generated with Claude Code

Multiple env_vars.yaml entries were missing PYAUTO_FAST_PLOTS from
their unset: list, leaving savefig short-circuited on the build
server (triage Cluster A — "fit.png was not produced",
"dataset.png missing"):

  - imaging/visualization.py: was [PYAUTO_SMALL_DATASETS] →
    [PYAUTO_FAST_PLOTS, PYAUTO_SMALL_DATASETS]
  - interferometer/visualization.py: was [PYAUTO_FAST_PLOTS] →
    [PYAUTO_FAST_PLOTS, PYAUTO_SMALL_DATASETS] (loads FITS at full
    res with explicit (100, 100) shape_native mask)
  - imaging/visualization_jax: was [PYAUTO_DISABLE_JAX,
    PYAUTO_SMALL_DATASETS] → also unset PYAUTO_FAST_PLOTS
  - point_source/visualization_jax: was [PYAUTO_DISABLE_JAX,
    PYAUTO_SMALL_DATASETS] → also unset PYAUTO_FAST_PLOTS

Also adds a new override for point_source/visualization.py (JSON
dataset, no FITS, no mask — PYAUTO_FAST_PLOTS alone is sufficient).

Updates the pattern-convention comment header to document that
patterns containing '/' substring-match against the full path
including extension (depends on PyAutoBuild #91).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Jammy2211 Jammy2211 added the pending-release PR queued for the next release build label May 20, 2026
@Jammy2211 Jammy2211 merged commit bc20580 into main May 20, 2026
4 checks passed
@Jammy2211 Jammy2211 deleted the feature/fast-plots-env-coverage branch May 20, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-release PR queued for the next release build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant