config(env_vars): repair FAST_PLOTS coverage for visualization scripts#107
Merged
Conversation
Multiple env_vars.yaml entries were missing PYAUTO_FAST_PLOTS from
their unset: list, leaving savefig short-circuited on the build
server (triage Cluster A — "fit.png was not produced",
"dataset.png missing"):
- imaging/visualization.py: was [PYAUTO_SMALL_DATASETS] →
[PYAUTO_FAST_PLOTS, PYAUTO_SMALL_DATASETS]
- interferometer/visualization.py: was [PYAUTO_FAST_PLOTS] →
[PYAUTO_FAST_PLOTS, PYAUTO_SMALL_DATASETS] (loads FITS at full
res with explicit (100, 100) shape_native mask)
- imaging/visualization_jax: was [PYAUTO_DISABLE_JAX,
PYAUTO_SMALL_DATASETS] → also unset PYAUTO_FAST_PLOTS
- point_source/visualization_jax: was [PYAUTO_DISABLE_JAX,
PYAUTO_SMALL_DATASETS] → also unset PYAUTO_FAST_PLOTS
Also adds a new override for point_source/visualization.py (JSON
dataset, no FITS, no mask — PYAUTO_FAST_PLOTS alone is sufficient).
Updates the pattern-convention comment header to document that
patterns containing '/' substring-match against the full path
including extension (depends on PyAutoBuild #91).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several
env_vars.yamloverride entries were missingPYAUTO_FAST_PLOTSfrom theirunset:list, so the build server keptPYAUTO_FAST_PLOTS=1set even for the visualization scripts that explicitly assert PNGs land on disk.PYAUTO_FAST_PLOTS=1short-circuitssubplot_save/save_figurein PyAutoArray — no PNG ever written, assertions fail with "fit.png was not produced" / "dataset.png missing" (triage Cluster A, plus the parked 40d-oldimaging/visualizationNEEDS_FIX entry).This PR closes the coverage gap for every affected script and adds a new override for
point_source/visualization.py(which had no entry at all).Configs Changed
config/build/env_vars.yaml:.py-anchored patterns.imaging/visualization.py: appendedPYAUTO_FAST_PLOTStounset:(was only unsettingPYAUTO_SMALL_DATASETS).interferometer/visualization.py: appendedPYAUTO_SMALL_DATASETStounset:— script loads FITS at full res with an explicit(100, 100)shape_nativemask, so the 15×15 cap mismatches even whenshape_nativeis explicit.imaging/visualization_jax: appendedPYAUTO_FAST_PLOTStounset:.point_source/visualization_jax: appendedPYAUTO_FAST_PLOTStounset:.point_source/visualization.py→unset: [PYAUTO_FAST_PLOTS](JSON dataset, no FITS, no mask —PYAUTO_FAST_PLOTSalone is sufficient).Upstream PR
PyAutoBuild #91 — depends on its
_pattern_matchesfix to make the existingimaging/visualization.pyandinterferometer/visualization.pyoverrides fire (previously dead because the matcher stripped.pyfrom the path before substring matching).Test Plan
build_env_for_scriptpipeline, with PyAutoBuild feat: autolens point_source JAX visualization scripts #91 applied): all 5 affected scripts pass — imaging 64.1s, interferometer 69.5s, point_source 20.0s, point_source_jax 41.6s, imaging_jax 123.8s./smoke_test autolens_testruns cleanly (visualization scripts are commented out insmoke_tests.txtfor an unrelated bypass-mode issue, so this PR is not directly exercised by smoke).Next triage cluster regen should clear the autolens entries of Cluster A and the parked
imaging/visualizationNEEDS_FIX.🤖 Generated with Claude Code