fix(cluster): keep cluster viz grid full-extent under PYAUTO_SMALL_DATASETS=1#109
Merged
Merged
Conversation
…TASETS=1 The cluster host's tangential critical curve sits at ~30-50"; the smoke-mode shrink (15x15 @ 0.6") would place it outside the visualization grid, silently breaking the assertion. Opt out via the new respect_small_datasets kwarg on Grid2D.uniform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass
respect_small_datasets=Falseto theviz_gridconstruction inscripts/cluster/visualization.py. The cluster's tangential critical curve falls at ~30-50" radius; the globalPYAUTO_SMALL_DATASETS=1shrink would collapse the 100"x100" grid to (15, 15) @ 0.6" (~8" extent), placing the entire grid inside the curve and silently breaking thetangential_curves recovered >= 1assertion.Triaged originally as a simulator regression / LensCalc multi-plane plumbing bug (Cluster H); verification on clean main showed both diagnoses were wrong. The actual fix is two library kwargs (already shipped) and this one-line script opt-out.
Scripts Changed
scripts/cluster/visualization.py—viz_gridpassesrespect_small_datasets=Falseplus a one-line comment explaining the constraint. No other change.Upstream PR
Test Plan
env PYAUTO_TEST_MODE=2 PYAUTO_SMALL_DATASETS=1 PYAUTO_DISABLE_JAX=1 PYAUTO_FAST_PLOTS=1 JAX_ENABLE_X64=True python3 scripts/cluster/visualization.pyrecoverstangential_curves recovered: 1 OKand printsAll visualization assertions passed.scripts/cluster/simulator.pystill passes under the same env (sanity).🤖 Generated with Claude Code