-
Notifications
You must be signed in to change notification settings - Fork 94
quick calibration for 4x and 20x objectives on cytation1 w/ 1288x964 pixel Blackfly BFLY-U3-13S2M sensor #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ben-ray
wants to merge
8
commits into
PyLabRobot:main
Choose a base branch
from
ben-ray:ray/add_fov_calculation_for_cytation1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cb35fa5
quick calibration 4x 20x
ben-ray 32cf9b7
ruff
ben-ray b96e1c5
switch to strings to fix autoreload issues
ben-ray 1bd000e
switch to strings to fix issues with autoreload
ben-ray 17c8068
reset sleep time oops
ben-ray 15ace2f
ruff again
ben-ray 196e824
fix typing
ben-ray cccc4d3
ruf
ben-ray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is going on with these denominators?
for the cytation5, it's to convert um to mm
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cytation5 sensor is 2448x2048 while the cytation1 is 1288x964. The scaling factor from pixel to micron will be identical for both axis, but why does the image_size conversion not take the sensor size into account? I would expect the X and Y size to be different but the scaling factor is identical in X and Y in the original Cytation5 implementation.
These numbers are my attempt to account for the significantly different x and y size of my sensor (my pixels are still perfectly square)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a scaling factor
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then how do I determine these and why are they not different for X and Y on the cytation5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i took the number from gen5.exe, and then did um -> mm conversion which seems to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least it corresponds with their firmware commands.
you can use a firmware command to check