-
Notifications
You must be signed in to change notification settings - Fork 916
feat: support pyclass on tuple enums #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4960de3
feat: support pyclass on tuple enums
newcomertv 53c95f6
cargo fmt
newcomertv e051a5f
changelog
newcomertv eaf5265
ruff format
newcomertv 51d434f
rebase with adaptation for FnArg refactor
newcomertv 9c540ed
fix class.md from pr comments
carderne 7b06fe5
add enum tuple variant getitem implementation
carderne 3c48775
fmt
carderne a2f582c
progress toward getitem and len impl on derive pyclass for complex en…
newcomertv d72a893
working getitem and len slots for complex tuple enum pyclass derivation
newcomertv 13aa7a0
refactor code generation
newcomertv 47cd6ce
address PR concerns
newcomertv 07710d3
add tracking issue
newcomertv 94da194
fmt
newcomertv 1921898
ruff
newcomertv 41a33ea
remove me
newcomertv 91c457f
support match_args for tuple enum
newcomertv 9ae0a48
integrate FnArg now takes Cow
newcomertv 73b7a8f
fix empty and single element tuples
newcomertv 5bd5690
use impl_py_slot_def for cimplex tuple enum slots
newcomertv 78d5078
reverse erroneous doc change
newcomertv 0761854
Address latest comments
newcomertv 7dd1a93
formatting suggestion
newcomertv 6d7596e
fix :
newcomertv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Support `#[pyclass]` on enums that have tuple variants. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.