Skip to content

Conversation

@tschm
Copy link
Contributor

@tschm tschm commented Nov 9, 2025

This dockerfile introduced by tschm is really no longer needed. We will work on a modern .devcontainer setup

@tschm
Copy link
Contributor Author

tschm commented Nov 9, 2025

@fkiraly All tests seem to work here?! The Dockerfile is obsolete. Later we could have .devcontainer which is much easier to use...

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, what if someone still relies on this? We need to think about the principle "do not delete working code".

Can we safely remove it?

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Nov 9, 2025
@fkiraly fkiraly changed the title remove docker [MNT] remove dockerfile Nov 9, 2025
@tschm
Copy link
Contributor Author

tschm commented Nov 10, 2025

It's very non-standard that a package would have its own Dockerfile in 2025. This was initially introduced to ensure developers work in an homogeneous environment. This task is now much better solved with .devcontainers. Of course, the Dockerfile is very simplisitc and any user can install the package in a Dockerimage if they really want to. We also don't publish the related image let alone build or test it. Better remove.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I can live with that. @robertmartin8 may also like to comment.

@fkiraly fkiraly merged commit 3329d84 into PyPortfolio:main Nov 10, 2025
15 checks passed
@fkiraly fkiraly mentioned this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants