Skip to content

FBBT: resolve bug registering native type handlers #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

As part of #3558 we hit a bug where NumPy types were not getting correctly registered with the FBBT before child dispatcher. This resolves the error and adds a test covering it.

Changes proposed in this PR:

  • Support automatic registration of native types for the FBBT before child dispatcher

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is insane how small and impactful this change is.

@github-project-automation github-project-automation bot moved this from Todo to Reviewer Approved in Pyomo Release April 2025 Apr 15, 2025
@jsiirola jsiirola changed the title FBT: resolve bug registering native type handlers FBBT: resolve bug registering native type handlers Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Reviewer Approved
Development

Successfully merging this pull request may close these issues.

2 participants