HW2_Grigoriants #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_python into HW2_Grigoriants
…Git_and_python into HW2_Grigoriants
…d_python into HW2_Grigoriants
…hon into HW2_Grigoriants
Hw2 grigoriants
Hw2 grigoriants
Add division function
…hon into HW2_Grigoriants
Now it's great
Add function minus
albidgy
reviewed
Sep 20, 2023
| @@ -0,0 +1,13 @@ | |||
| # HW2_Git_and_python by Git Dream Team | |||
| Наша команда обеспечила Github комьюнити новейшим вычислительным механизмом. С её помощью школьная арифметика больше не создаст ни для кого проблем! Программа принимает на вход строку с некоторым математическим выражением и выводит число - результат вычисления этого выражения. | |||
|
|
|||
There was a problem hiding this comment.
Есть 2 пожелания:
- пишите README на английском языке, чтобы в будущем ваш код могло использовать не только русско-говорящее сообщество. Лучше сразу привыкать;
- полезно приводить примеры кода, потому что по вашему описанию можно подать математическое выражение 1+2 и тогда ничего не сработает.
| else: | ||
| return num1 / num2 | ||
|
|
||
| def plus(num1, num2): #sum of numbers |
There was a problem hiding this comment.
На будущее: # комментарий отделяют от кода двумя пробелами
Comment on lines
+19
to
+21
| num1 = float(my_string.split()[0]) | ||
| num2 = float(my_string.split()[2]) | ||
| sign = my_string.split()[1] |
There was a problem hiding this comment.
в целом рабочий вариант, но есть переиспользование кода, лучше было бы сделать так:
Suggested change
| num1 = float(my_string.split()[0]) | |
| num2 = float(my_string.split()[2]) | |
| sign = my_string.split()[1] | |
| num1, sign, num2 = my_string.split() | |
| num1 = float(num1) | |
| num2 = float(num2) |
| ans = multiplication(num1, num2) | ||
| elif sign == "/": | ||
| ans = division(num1, num2) | ||
| return ans |
There was a problem hiding this comment.
Обратите внимание: по PEP8 после функции идет пропуск 2х строк.
| ans = division(num1, num2) | ||
| return ans | ||
| answer = main() | ||
| print(answer) |
There was a problem hiding this comment.
Хороший нейминг. В целом код написан акуратно.
| def multiplication(num1, num2): #multiplication of numbers | ||
| return num1 * num2 | ||
|
|
||
| def minus (num1, num2): |
There was a problem hiding this comment.
Suggested change
| def minus (num1, num2): | |
| def minus(num1, num2): |
albidgy
reviewed
Sep 20, 2023
| ### This will be our great calculator. Please contribute by writing one of the functions | ||
| def division(num1, num2): #division of numbers | ||
| if num2 == 0: | ||
| return "Dude, for real?" |
There was a problem hiding this comment.
Когда вы проводите операции над числами, вы ожидаете, что на выходе получите другое число. Здесь же вернется строка. В таких ситуациях лучше останавливать программу и выбрасывать ошибку. Например:
Suggested change
| return "Dude, for real?" | |
| print('Dude, for real?', file=sys.stderr) | |
| os.exit(1) |
С модулями sys и os вы еще познакомитесь:)
albidgy
reviewed
Sep 20, 2023
| def division(num1, num2): #division of numbers | ||
| if num2 == 0: | ||
| return "Dude, for real?" | ||
| else: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homework done by Git Dream Team, teamlead - Grigoriants