Skip to content

Conversation

@AnneKlapwijk
Copy link
Member

@AnneKlapwijk AnneKlapwijk commented Apr 9, 2025

run-name: Running Dependency Submission

on:
workflow_dispatch:
Copy link
Collaborator

@ninovanhooff ninovanhooff Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what process will call this workflow? At what frequency?

Copy link
Collaborator

@ninovanhooff ninovanhooff Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the reference here https://github.com/marketplace/actions/build-with-gradle#the-dependency-submission-action

And also the PostNL one get triggered by pushes to branches

Either change the trigger or add a comment explaning the current one

Copy link
Collaborator

@ninovanhooff ninovanhooff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnneKlapwijk.

This would be a nice addition, but the trigger for this workflow is unclear to me

@@ -0,0 +1,25 @@
# https://docs.github.com/en/code-security/dependabot/ecosystems-supported-by-dependabot/supported-ecosystems-and-repositories#gradle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run-name: Running Dependency Submission

on:
workflow_dispatch:
Copy link
Collaborator

@ninovanhooff ninovanhooff Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the reference here https://github.com/marketplace/actions/build-with-gradle#the-dependency-submission-action

And also the PostNL one get triggered by pushes to branches

Either change the trigger or add a comment explaning the current one

- name: Setup Java
uses: actions/setup-java@v4
with:
distribution: "temurin"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use corretto 21 elsewhere, might be nice to keep that in sync. Corretto might advantages for Apple silicon. https://whichjdk.com/#apple-silicon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants