Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase documentation of ParameterVector and ParameterVectorElement #13761

Open
wants to merge 1 commit into from

Conversation

jakelishman
Copy link
Member

Summary

These were somewhat lacking before, despite being fairly heavily used. ParameterVectorElement was not publicly documented, despite adding additional properties that were intended for public use.

Details and comments

These were somewhat lacking before, despite being fairly heavily used.
`ParameterVectorElement` was not publicly documented, despite adding
additional properties that were intended for public use.
@jakelishman jakelishman added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jan 30, 2025
@jakelishman jakelishman requested a review from a team as a code owner January 30, 2025 14:49
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13054802059

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 88.942%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.23%
Totals Coverage Status
Change from base Build 13053673557: 0.006%
Covered Lines: 79689
Relevant Lines: 89597

💛 - Coveralls

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I won't put it on the merge queue since Luciano is assigned 🙂

@jakelishman
Copy link
Member Author

Oh, Luciano's just assigned because this just came out of a meeting he and I were in together. It was more an FYI, and I assumed others were busy.

@Cryoris
Copy link
Contributor

Cryoris commented Jan 31, 2025

In that case....

@Cryoris Cryoris added this pull request to the merge queue Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants