Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Incorrect initialization of BackendV2 for transpiler_level ASV Test #14152

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

raynelfss
Copy link
Contributor

Summary

After the removal of BackendV1 in #13793, and the prospective updates done by #13805, the transpiler_level tests are no longer working due to an erroneous initialization of a GenericBackendV2 in which the number of qubits on the backend did not match the number of qubits in the coupling map. The following commits fix said issue by ensuring both of these parameters match.

@raynelfss raynelfss added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Apr 1, 2025
@raynelfss raynelfss requested a review from a team as a code owner April 1, 2025 17:47
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. We've been missing the data from these benchmarks for some time so it'll be good to fix this. I ran asv locally and confirmed it fixes the run too.

@mtreinish mtreinish enabled auto-merge April 1, 2025 18:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14202490169

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 88.074%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.79%
crates/qasm2/src/lex.rs 3 92.98%
Totals Coverage Status
Change from base Build 14202044040: 0.02%
Covered Lines: 72821
Relevant Lines: 82682

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Apr 1, 2025
Merged via the queue into Qiskit:main with commit 99d0fa9 Apr 1, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants