Skip to content

Migrated to NetStandard 2.0 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dannykQuali wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Migrated to NetStandard 2.0 #54

dannykQuali wants to merge 9 commits into from

Conversation

@dannykQuali
Copy link
Collaborator

@dannykQuali dannykQuali commented Jul 20, 2023

Description

  • Converted Toscana and Toscana.Tests projects to SDK-style format.
  • Updated NuGet packages to their latest NetStandard2.0 versions.
  • Updated the code and tests to accommodate for breaking API and behavior changes in the NuGet packages.
  • Updated the Tests project NuGet packages to be compatible with Visual Studio 2022 test platform.
  • Configured Tests project to run on multi targeting: net461;net472;netcoreapp3.1;net5.0;net6.0;net7.0

Breaking

YES

Breaking changes

  • Assemblies are not signed with a strong name anymore.
  • BindingRedirect is now required to load dependencies properly on .NET Framework 4.7.1 and below. This is a limitation of NetStandard2.0. See Toscana.Tests\app.config for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nahumtimerman nahumtimerman nahumtimerman approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dannykQuali @nahumtimerman @DxCK