Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local channel_name variable instead of global channel #17

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Nov 11, 2024

This issue prevented URLs copied from the address bar from working. We can avoid this in the future if we use the global context as little as possible, even though that's not idiomatic for Streamlit.

Cc @pavelzw

Copy link
Contributor

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @jaimergp could you take a look as well?

@jaimergp jaimergp merged commit 2a9a222 into Quansight-Labs:main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants